[release-v1.62] Authorize default SA on DataImportCron PVC source #3972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubevirt#3950)" This reverts commit 646c142. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
added
release-note
arnongilboa
force-pushed
the
dic_sa-v1.62
branch
from
78b28f4 to
d326bca
Compare
Collaborator
Author
|
/test pull-cdi-verify-go-mod |
Collaborator
Author
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
arnongilboa
force-pushed
the
dic_sa-v1.62
branch
from
d326bca to
0a8fed9
Compare
In case of DataImportCron with PVC source, the controller checks the namespace default ServiceAccount is authorized to clone the source PVC. This is a minimally partial backport of kubevirt#3970. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
dic_sa-v1.62
branch
from
0a8fed9 to
d1dc22b
Compare
Collaborator
Author
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
Collaborator
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In case of
DataImportCronwith PVC source, the controller checks the namespace defaultServiceAccountis authorized to clone the source PVC.This is a minimally partial backport of #3970.
Release note: