fix: edit install approxy db logic for package mode #6504
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| dsn = ( | ||
| f"postgresql+asyncpg://appproxy:develove@" | ||
| f"{halfstack.postgres_addr.face.host}:{halfstack.postgres_addr.face.port}/appproxy" | ||
| ) |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| database="backend", | ||
| ) | ||
| await core_conn.execute( | ||
| """ |
Check warning
Code scanning / devskim
An HTTP-based URL without TLS was detected. Warning
| # TODO: multi-node setup | ||
| public_facing_address = self.install_variable.public_facing_address | ||
| if public_facing_address in ("127.0.0.1", "0.0.0.0"): | ||
| if public_facing_address in ("127.0.0.1", "localhost"): |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
| # TODO: multi-node setup | ||
| public_facing_address = self.install_variable.public_facing_address | ||
| if public_facing_address in ("127.0.0.1", "0.0.0.0"): | ||
| if public_facing_address in ("127.0.0.1", "localhost"): |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
HyeockJinKim
force-pushed
the
main
branch
4 times, most recently
from
1a10632 to
2d8c9ea
Compare
| self.log.write("install rover cli ..") | ||
| await self.install_rover_cli() | ||
|
|
||
| # TODO: 설치할 때 routing url이 달라질수 있으니 인스톨러에서 flag로 세팅하여 routing_url 수정하도록 변경필요 |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| cert_path = ssl_dir / "manager-api-selfsigned.cert.pem" | ||
| key_path = ssl_dir / "manager-api-selfsigned.key.pem" | ||
|
|
||
| # TODO: If the user disables SSL in the configuration, skip creating the PEM files. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
resolves #NNN (BA-MMM)
Checklist: (if applicable)
ai.backend.testdocsdirectory