From 0795f7bcfe15b5637092b9e050ea6144e6757791 Mon Sep 17 00:00:00 2001 From: laboon Date: Tue, 10 Nov 2015 10:52:00 -0500 Subject: [PATCH 1/2] derp changes --- com/laboon/Cell.java | 6 +++--- com/laboon/JavaLife.java | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/com/laboon/Cell.java b/com/laboon/Cell.java index f700d80..4d34ad2 100644 --- a/com/laboon/Cell.java +++ b/com/laboon/Cell.java @@ -66,11 +66,11 @@ public State iterate(int numNeighbors) { public char getStateRep() { char toReturn = ' '; if (_state == State.DEAD) { - toReturn = '.'; + toReturn = ' '; } else if (_state == State.ALIVE) { - toReturn = 'X'; + toReturn = '*'; } else { - toReturn = '?'; + toReturn = ' '; } return toReturn; } diff --git a/com/laboon/JavaLife.java b/com/laboon/JavaLife.java index f5c5a8e..8f5bcd3 100644 --- a/com/laboon/JavaLife.java +++ b/com/laboon/JavaLife.java @@ -4,8 +4,8 @@ public class JavaLife { /** * - * @param size Size of world - * @param seed Random number seed + * @param size Size of a world + * @param seed Random number seed for RNG * @param percent Percent of cells alive at beginning * @param maxIterations Maximum number of iterations */ @@ -13,9 +13,9 @@ public class JavaLife { public JavaLife(int size, int seed, int percent, int maxIterations) { World w = new World(size, seed, percent); System.out.println("Initial Configuration:"); - System.out.println(w.toString()); + System.out.println( w.toString() ); for (int j=0; j < maxIterations; j++) { - w = w.iterate(); + w = w.iterate(); System.out.println("Iteration " + (j + 1) + ":"); System.out.println(w.toString()); } From def955004add06a4417032ee966bb464281cc0ac Mon Sep 17 00:00:00 2001 From: Stephen Snow Date: Mon, 16 Oct 2017 15:55:38 -0400 Subject: [PATCH 2/2] Optmized toString using StringBuilder --- com/laboon/World.java | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/com/laboon/World.java b/com/laboon/World.java index 98b037c..437d895 100644 --- a/com/laboon/World.java +++ b/com/laboon/World.java @@ -1,6 +1,7 @@ package com.laboon; import java.util.Random; +import java.lang.StringBuilder; public class World { @@ -115,19 +116,19 @@ public World iterate() { */ public String toString() { - String toReturn = " "; + StringBuilder toReturn = new StringBuilder(" "); for (int j= 0; j < _size; j++) { - toReturn += String.valueOf(j % 10); + toReturn.append(String.valueOf(j % 10)); } - toReturn += "\n"; + toReturn.append("\n"); for (int j = 0; j < _size; j++ ) { - toReturn += String.valueOf(j % 10) + " "; + toReturn.append(String.valueOf(j % 10) + " "); for (int k = 0; k < _size; k++) { - toReturn += (_world[j][k].getStateRep()); + toReturn.append(_world[j][k].getStateRep()); } - toReturn += "\n"; + toReturn.append("\n"); } - return toReturn; + return toReturn.toString(); } /**