Skip to content

fix(polyface): Remove the angle tolerance requirement for polyface solid #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriswmackey merged 1 commit into from
Aug 11, 2025
Merged

fix(polyface): Remove the angle tolerance requirement for polyface solid #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ladybug_geometry/geometry3d/line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from __future__ import division

from .pointvector import Point3D, Vector3D
from ..intersection3d import closest_point3d_on_line3d_infinite
from ._1d import Base1DIn3D


Expand Down Expand Up @@ -123,6 +124,32 @@ def is_vertical(self, tolerance):
"""
return abs(self.v.x) <= tolerance and abs(self.v.y) <= tolerance

def is_colinear(self, line_ray, tolerance, angle_tolerance=None):
"""Test whether this object is colinear to another LineSegment3D or Ray3D.

Args:
line_ray: Another LineSegment3D or Ray3D for which co-linearity
with this object will be tested.
tolerance: The maximum distance between the line_ray and the infinite
extension of this object for them to be considered colinear.
angle_tolerance: The max angle in radians that the direction between
this object and another can vary for them to be considered
parallel. If None, the angle tolerance will not be used to
evaluate co-linearity and the lines will only be considered
colinear if the endpoints of one line are within the tolerance
distance of the other line. (Default: None).
"""
if angle_tolerance is not None and \
not self.is_parallel(line_ray, angle_tolerance):
return False
_close_pt = closest_point3d_on_line3d_infinite(self.p1, line_ray)
if self.p1.distance_to_point(_close_pt) >= tolerance:
return False
_close_pt = closest_point3d_on_line3d_infinite(self.p2, line_ray)
if self.p2.distance_to_point(_close_pt) >= tolerance:
return False
return True

def flip(self):
"""Get a copy of this line segment that is flipped."""
return LineSegment3D(self.p2, self.v.reverse())
Expand Down
9 changes: 6 additions & 3 deletions ladybug_geometry/geometry3d/polyface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ def is_solid(self):
"""
return self._is_solid

def merge_overlapping_edges(self, tolerance, angle_tolerance):
def merge_overlapping_edges(self, tolerance, angle_tolerance=None):
"""Get this object with overlapping naked edges merged into single internal edges

This can be used to determine if a polyface is truly solid since this check
Expand All @@ -447,8 +447,11 @@ def merge_overlapping_edges(self, tolerance, angle_tolerance):
Args:
tolerance: The minimum distance between a vertex and the boundary segments
at which point the vertex is considered colinear.
angle_tolerance: The max angle in radians that vertices are allowed to
differ from one another in order to consider them colinear.
angle_tolerance: An optional maximum angle in radians to dictate
whether polyface edges are colinear with one another. If None,
the solidity of the polyface will be determined using only the
absolute distance of vertices to polyface edges in relation to
the tolerance. (Default: None).
"""
# get naked edges
naked_edges = list(self.naked_edges)
Expand Down
Loading