Skip to content

fix(network): Ensure degenerate holes cannot break routine #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriswmackey merged 1 commit into from
Jan 30, 2026
+10 −5
Merged

fix(network): Ensure degenerate holes cannot break routine #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ladybug_geometry/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,16 @@ def from_shape_to_split(cls, boundary, holes, split_segments, tolerance):
if holes is not None:
split_holes = []
for hole in holes:
hole = hole.remove_colinear_vertices(tolerance)
hole_sgs = cls._intersect_segments(
hole.segments, split_segments, tolerance)
hole_pts = [seg.p1 for seg in hole_sgs]
split_holes.append(boundary.__class__(hole_pts))
try:
hole = hole.remove_colinear_vertices(tolerance)
hole_sgs = cls._intersect_segments(
hole.segments, split_segments, tolerance)
hole_pts = [seg.p1 for seg in hole_sgs]
split_holes.append(boundary.__class__(hole_pts))
except AssertionError:
pass # degenerate hole to ignore
if len(split_holes) == 0:
split_holes = None

# make the directed graph for the boundary + holes
dg = cls.from_shape_with_holes(split_boundary, split_holes, tolerance)
Expand Down