Skip to content

Commit 060b0ec

Browse files
Improved formatting of feedback
1 parent 4cbccf3 commit 060b0ec

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

app/evaluation.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,13 +90,26 @@ def evaluation_function(response, answer, params):
9090

9191
remark = ""
9292

93+
onedim_format = lambda x: "Entry "+str(x[1][0])
94+
table_format = lambda x: "Entry on row "+str(x[1][0])+", column "+str(x[1][1])
95+
general_format = lambda x: "Entry ("+"".join([str(i) for i in x[1][0:-1])+","])+str(x[1][-1])+")"
96+
97+
feedback_format = general_format
98+
99+
if all([not isinstance(item,list) for item in feedback]):
100+
feedback_format = onedim_format
101+
elif len(feedback) == 1 and all(not isinstance(feedback[0],list)):
102+
feedback_format = onedim_format
103+
elif all([isinstance(elem,list) for elem in feedback]) and\
104+
all([len(elem) == len(feedback[0]) for elem in feedback]):
105+
feedback_format = table_format
93106
for item in feedback:
94107
content = detailed_feedback[item[1][0]-1]
95108
for k in range(1,len(item[1])):
96109
content = content[item[1][k]-1]
97110
if "feedback" in content.keys():
98111
separator = "" if len(remark) == 0 else "\n"
99-
remark += separator+"Entry on row "+str(item[1][0])+" column "+str(item[1][1])+": "+content["feedback"]
112+
remark += separator+feedback_format(item)+": "+content["feedback"]
100113

101114
# Correct case
102115
if all(item[0] == "correct" for item in feedback):

0 commit comments

Comments
 (0)