-
-
Notifications
You must be signed in to change notification settings - Fork 78
Closed
Description
This PR provides changes described in #365
A few questions came up while refactoring. Some feedback is appreciated:
- Setter returns are inconsistent (e.g.
ColumnObjectandConstraintKeyObject). Since there are fluent setters, possibility is that they are being used. Therefore I recommend to unify and make all setters fluent. If that is okay, I'll provide the changes in this scope. - Unsure where class constants of
ConstraintKeyObjectandAbstractSourceare used. Currently the visibility is defined aspublic. If they are not needed elsewhere,privateorprotectedmight be more suitable. - The
$tableparameter ofloadConstraintData()andloadConstraintReferences()in classZend\Db\Metadata\Source\AbstractSourceis unused. Version 3.0 might be a good time to remove it (causing BC). Should I include this change in this scope?
Originally posted by @arueckauer at zendframework/zend-db#369
Metadata
Metadata
Assignees
Labels
No labels