simpler image optimisation

Author: simonswiss

app/Actions/OptimizeWebpImageAction.php

@@ -8,20 +8,10 @@
 
 class OptimizeWebpImageAction
 {
-    public function handleFromUploadedFile(UploadedFile $file): array
-    {
-        return $this->optimize($file->getRealPath());
-    }
-
-    public function handleFromPath(string $path): array
-    {
-        return $this->optimize($path);
-    }
-
-    protected function optimize(string $path): array
+    public function handle(string $input): array
     {
         // Image optimization
-        $image = Image::read($path);
+        $image = Image::read($input);
 
         // Scale down only
         if ($image->width() > 1000) {

app/Http/Controllers/PuppyController.php

@@ -64,7 +64,7 @@ public function store(Request $request)
         $image_url = null;
         if ($request->hasFile('image')) {
 
-            $optimized = (new OptimizeWebpImageAction())->handleFromUploadedFile($request->file('image'));
+            $optimized = (new OptimizeWebpImageAction())->handle($request->file('image'));
 
             $path = 'puppies/' . $optimized['fileName'];
 

database/seeders/PuppySeeder.php

@@ -141,16 +141,16 @@ public function run(): void
         $optimizer = new OptimizeWebpImageAction();
 
         foreach ($puppies as $puppy) {
-            $storagePath = storage_path('app/public/puppies/' . $puppy['image']);
-            $optimized = $optimizer->handleFromPath($storagePath);
 
+            // Optimize the image
+            $input = storage_path('app/public/puppies/' . $puppy['image']);
+            $optimized = $optimizer->handle($input);
+
+            // Grab the path of the image
             $path = 'puppies/' . $optimized['fileName'];
-            $stored = Storage::disk('public')->put($path, $optimized['webpString']);
 
-            if (!$stored) {
-                dump('Failed to store image: ' . $puppy['image']);
-                continue;
-            }
+            // Store that image
+            Storage::disk('public')->put($path, $optimized['webpString']);
 
             Puppy::create([
                 'user_id' => $simon->id,