WIP corrected ParameterResolver

Author: mgerzabek

CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
+## [1.0.0-RC5] - 2025-09-
+
+
 ## [1.0.0-RC4] - 2025-09-19
 - Documentation tweaks
 - AbstractActionHandler implements ParameterizableInterface

src/Exceptions/MissingUriKeyException.php

@@ -19,7 +19,6 @@
 use LaravelUi5\Core\Exceptions\InvalidParameterValueException;
 use LaravelUi5\Core\Exceptions\InvalidPathException;
 use LaravelUi5\Core\Exceptions\MissingRequiredParameterException;
-use LaravelUi5\Core\Exceptions\MissingUriKeyException;
 use LaravelUi5\Core\Exceptions\NoModelFoundForParameterException;
 use LaravelUi5\Core\Ui5\Contracts\ParameterizableInterface;
 use ReflectionClass;
@@ -40,6 +39,7 @@ public function resolve(ParameterizableInterface $target): Ui5Args
         $attributes = $reflection->getAttributes(Parameter::class);
         $uriKeys = $this->getUriKeys();
         $out = [];
+        $index = 0;
 
         /** @var Parameter $attribute */
         foreach ($attributes as $a) {
@@ -50,10 +50,7 @@ public function resolve(ParameterizableInterface $target): Ui5Args
             // 1. Get the raw value
             switch ($attribute->source) {
                 case ParameterSource::Path:
-                    if (null === $attribute->uriKey) {
-                        throw new MissingUriKeyException($name);
-                    }
-                    $raw = $uriKeys[$attribute->uriKeyPosition] ?? null;
+                    $raw = $uriKeys[$index] ?? null;
                     break;
                 case ParameterSource::Query:
                     $raw = $this->request->query($name);

src/Services/ParameterResolver.php

@@ -4,9 +4,8 @@
 
 use LaravelUi5\Core\Contracts\Ui5Args;
 use LaravelUi5\Core\Ui5\Contracts\ActionHandlerInterface;
-use LaravelUi5\Core\Ui5\Contracts\ParameterizableInterface;
 
-abstract class AbstractActionHandler implements ActionHandlerInterface, ParameterizableInterface
+abstract class AbstractActionHandler implements ActionHandlerInterface
 {
     protected Ui5Args $args;
 

src/Ui5/AbstractActionHandler.php

@@ -8,7 +8,7 @@
 use LaravelUi5\Core\Exceptions\InvalidParameterSourceException;
 use LaravelUi5\Core\Ui5\Contracts\LaravelUi5ManifestInterface;
 use LaravelUi5\Core\Ui5\Contracts\LaravelUi5ManifestKeys;
-use LaravelUi5\Core\Ui5\Contracts\Ui5ActionInterface;
+use LaravelUi5\Core\Ui5\Contracts\ParameterizableInterface;
 use LaravelUi5\Core\Ui5\Contracts\Ui5RegistryInterface;
 use ReflectionClass;
 use RuntimeException;
@@ -87,7 +87,7 @@ protected function buildActions(string $module): array
                 throw new InvalidHttpMethodActionException($action->getNamespace(), $action->getMethod()->label());
             }
 
-            $uri = collect($this->getPathParameters($action))
+            $uri = collect($this->getPathParameters($action->getHandler()))
                 ->map(fn(string $parameter) => "/{{$parameter}}")
                 ->implode('');
 
@@ -100,9 +100,9 @@ protected function buildActions(string $module): array
         return $actions;
     }
 
-    protected function getPathParameters(Ui5ActionInterface $action): array
+    protected function getPathParameters(ParameterizableInterface $target): array
     {
-        $reflection = new ReflectionClass($action);
+        $reflection = new ReflectionClass($target);
         $attributes = $reflection->getAttributes(Parameter::class);
         $parameters = [];
         foreach ($attributes as $attr) {

src/Ui5/AbstractLaravelUi5Manifest.php

@@ -23,14 +23,12 @@
  *   feature flags that influence runtime behavior.
  *
  * Notes:
- * - URI parameters are resolved at the Action level (via
- *   {@see Ui5ActionInterface} + {@see ParameterizableInterface}),
- *   not on the handler itself.
+ * - Input expectations are declared via {@see ParameterizableInterface},
  * - ActionHandlers must always return a structured result, even if
  *   no payload is strictly required (e.g., a simple status + message).
  * - Dependencies (repositories, services) should be injected via
  *   constructor dependency injection for testability and clarity.
  */
-interface ActionHandlerInterface extends ExecutableInterface
+interface ActionHandlerInterface extends ExecutableInterface, ParameterizableInterface
 {
 }

src/Ui5/Contracts/ActionHandlerInterface.php

@@ -16,16 +16,14 @@
  * Characteristics:
  * - Actions are always *mutating* operations (never pure reads).
  * - Therefore, they must only be exposed as *POST endpoints*.
- * - Route parameters (IDs, slugs) are declared on the Action and resolved
+ * - Route parameters (IDs, slugs) are declared on the ActionHandler and resolved
  *   via {@see ParameterizableInterface}. The dispatcher validates and
  *   injects these before calling the handler.
  * - Body parameters (form data, payloads) are validated *inside the
  *   ActionHandler*, following Laravel best practices.
  *
  * Responsibilities:
  * - Define the action’s slug (via {@see SluggableInterface}).
- * - Optionally implement {@see ParameterizableInterface} to declare
- *   URI parameters.
  * - Provide the {@see ActionHandlerInterface} that executes the logic.
  *
  * Each Action must have a unique slug within its module. The slug is used