incorrect container size in iPhone landscape mode

[haifengkao]

I want to resize my controls to avoid the ad banner occluding them.
However, the containerView's height (50) is much larger than the height of admob's banner (32). It leaves an unpleasant blank between the controls and the banner.

[larsacus]

Since different ad networks will have ad banners with varying sizes, the ad container was built to accommodate the largest common denominator of the networks I support. I simply haven't designed in support for shrinking the container to fit the content it is displaying at the current point in time.

[haifengkao]

I guess I have to do it myself :(
Is it a viable solution to shrink the container based on the size of its largest subview?

[larsacus]

Yes, I would be happy to accept a pull request for functionality that has not been thought of or built yet.—
Sent from Mailbox

On Fri, Apr 25, 2014 at 1:45 PM, Hai Feng Kao notifications@github.com
wrote:

I guess I have to do it myself :(

Is it a viable solution to shrink the container based on the size of its largest subview?

Reply to this email directly or view it on GitHub:
#76 (comment)

[haifengkao]

This issue cannot be solved by the current design of LARSAdController. Reason: the ad view is a subview of parentView. If I shrink parentView to avoid the overlapping with the ad view, the ad view has to be put outside the bound of parentView. It makes the ad view non-clickable.

[larsacus]

You would not resize parentView, but adjust your sibling subviews to compensate for the ad's presence.—
Sent from Mailbox

On Thu, May 1, 2014 at 11:27 AM, Hai Feng Kao notifications@github.com
wrote:

This issue cannot be solved by the current design of LARSAdController. Reason: the ad view is a subview of parentView. If I shrink parentView to avoid the overlapping with the ad view, the ad view has to be put outside the bound of parentView. It makes the ad view non-clickable.

Reply to this email directly or view it on GitHub:
#76 (comment)

[haifengkao]

Thanks for the tip. I got a little problem though. It is difficult to figure out the correct layout for these subviews in different orientations. If I shrink the subviews in portrait orientation, the layout might be messed up when the device rotates to landscape.

[larsacus]

You can use autoresizing masks or auto layout to compensate your layout for the varying height of the ad container.

[haifengkao]

If I adjust the height of parentView, the auto layout will be applied to its subviews automatically. If I adjust the height of the subviews, the layout will be messed up.

[haifengkao]

I believe we need a better API to support the "shrinking the container to fit the content" feature.