prepare 5.7.1 release (#106)

Author: eli-darkly

CHANGELOG.md

@@ -2,7 +2,9 @@
 
 All notable changes to the LaunchDarkly .NET Server-Side SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
-## [5.7.0] - 2019-09-12
+## [5.7.1] - 2019-09-12
+_(The changes below were originally released in 5.7.0, but that release was broken; 5.7.1 is its replacement.)_
+
 This release includes new types and deprecations that correspond to upcoming changes in version 6.0.0. Developers are encouraged to start adopting these changes in their code now so that migrating to 6.0.0 in the future will be easier. Most of these changes are related to the use of mutable types, which are undesirable in a concurrent environment. `User` and `Configuration` are currently mutable types; they will be made immutable in the future, so there are now builders for them. Arbitrary JSON values are currently represented with the `Newtonsoft.Json` type `JToken`, which is mutable (if it contains an array or a JSON object); the new type `LdValue` is safer, and will eventually completely replace `JToken` in the public API.
 
 Also, generated HTML documentation for all of the SDK's public types, properties, and methods is now available online at https://launchdarkly.github.io/dotnet-server-sdk/. Currently this will only show the latest released version.

src/LaunchDarkly.ServerSdk/LaunchDarkly.ServerSdk.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <Version>5.7.0</Version>
+    <Version>5.7.1</Version>
     <TargetFrameworks>netstandard1.4;netstandard1.6;netstandard2.0;net45</TargetFrameworks>
     <PackageLicenseUrl>https://raw.githubusercontent.com/launchdarkly/dotnet-server-sdk/master/LICENSE</PackageLicenseUrl>
     <DebugType>portable</DebugType>

src/LaunchDarkly.ServerSdk/LdClient.cs

@@ -345,7 +345,7 @@ private EvaluationDetail<T> Evaluate<T>(string featureKey, User user, LdValue de
                 }
                 else
                 {
-                    if (checkType && evalDetail.Value.Type != defaultValue.Type)
+                    if (checkType && !defaultValue.IsNull && evalDetail.Value.Type != defaultValue.Type)
                     {
                         Log.ErrorFormat("Expected type: {0} but got {1} when evaluating FeatureFlag: {2}. Returning default",
                             defaultValue.Type,

test/LaunchDarkly.ServerSdk.Tests/LdClientEvaluationTest.cs

@@ -171,12 +171,27 @@ public void StringVariationReturnsFlagValue()
             Assert.Equal("b", client.StringVariation("key", user, "a"));
         }
 
+        [Fact]
+        public void StringVariationWithNullDefaultReturnsFlagValue()
+        {
+            featureStore.Upsert(VersionedDataKind.Features,
+                new FeatureFlagBuilder("key").OffWithValue(new JValue("b")).Build());
+
+            Assert.Equal("b", client.StringVariation("key", user, null));
+        }
+
         [Fact]
         public void StringVariationReturnsDefaultValueForUnknownFlag()
         {
             Assert.Equal("a", client.StringVariation("key", user, "a"));
         }
 
+        [Fact]
+        public void StringVariationWithNullDefaultReturnsDefaultValueForUnknownFlag()
+        {
+            Assert.Null(client.StringVariation("key", user, null));
+        }
+
         [Fact]
         public void StringVariationReturnsDefaultValueForWrongType()
         {