Merge pull request #18 from launchdarkly/pk/fix-non-string-rules

fixed logic for rules written using non-string values

Author: pkaeding

src/main/java/com/launchdarkly/client/LDUser.java

@@ -269,6 +269,17 @@ public Builder custom(String k, Number n) {
       return this;
     }
 
+    /**
+     * Add a {@link java.lang.Boolean}-valued custom attribute
+     * @param k the key for the custom attribute
+     * @param b the value for the custom attribute
+     * @return the builder
+     */
+    public Builder custom(String k, Boolean b) {
+      custom.put(k, new JsonPrimitive(b));
+      return this;
+    }
+
     /**
      * Add a list of {@link java.lang.String}-valued custom attributes
      * @param k the key for the list

src/main/java/com/launchdarkly/client/Variation.java

@@ -3,6 +3,7 @@
 
 import com.google.gson.JsonArray;
 import com.google.gson.JsonElement;
+import com.google.gson.JsonPrimitive;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -160,7 +161,14 @@ else if (values.contains(elt.getAsString())) {
             return false;
           }
           else if (custom.isJsonPrimitive()) {
-            return values.contains(custom.getAsString());
+            JsonPrimitive prim = custom.getAsJsonPrimitive();
+            if (prim.isNumber()) {
+              return values.contains(custom.getAsDouble());
+            } else if (prim.isBoolean()) {
+              return values.contains(custom.getAsBoolean());
+            } else {
+              return values.contains(custom.getAsString());
+            }
           }
         }
         return false;

src/test/java/com/launchdarkly/client/FeatureRepTest.java

@@ -12,21 +12,34 @@ public class FeatureRepTest {
 
   private final Variation.TargetRule targetGroupOn = new Variation.TargetRule("groups", Arrays.<Object>asList("google", "microsoft"));
 
+  // GSON will deserialize numbers as decimals
+  private final Variation.TargetRule targetFavoriteNumberOn = new Variation.TargetRule("favorite_number", Arrays.<Object>asList(42.0));
+
+  private final Variation.TargetRule targetLikesCatsOn = new Variation.TargetRule("likes_cats", Arrays.<Object>asList(true));
+
   private final Variation.TargetRule targetUserOff = new Variation.TargetRule("key", Collections.<Object>singletonList("targetOff@test.com"));
 
   private final Variation.TargetRule targetGroupOff = new Variation.TargetRule("groups", Arrays.<Object>asList("oracle"));
 
+  private final Variation.TargetRule targetFavoriteNumberOff = new Variation.TargetRule("favorite_number", Arrays.<Object>asList(33.0));
+
+  private final Variation.TargetRule targetLikesDogsOff = new Variation.TargetRule("likes_dogs", Arrays.<Object>asList(false));
+
   private final Variation.TargetRule targetAnonymousOn = new Variation.TargetRule("anonymous", Collections.<Object>singletonList(true));
 
   private final Variation<Boolean> trueVariation = new Variation.Builder<Boolean>(true, 80)
       .target(targetUserOn)
       .target(targetGroupOn)
       .target(targetAnonymousOn)
+      .target(targetLikesCatsOn)
+      .target(targetFavoriteNumberOn)
       .build();
 
   private final Variation<Boolean> falseVariation = new Variation.Builder<Boolean>(false, 20)
       .target(targetUserOff)
       .target(targetGroupOff)
+      .target(targetFavoriteNumberOff)
+      .target(targetLikesDogsOff)
       .build();
 
   private final FeatureRep<Boolean> simpleFlag = new FeatureRep.Builder<Boolean>("Sample flag", "sample.flag")
@@ -95,6 +108,28 @@ public void testFlagForTargetGroupOn() {
     assertEquals(true, b);
   }
 
+  @Test
+  public void testFlagForTargetNumericTestOn() {
+    LDUser user = new LDUser.Builder("targetOther@test.com")
+        .custom("favorite_number", 42.0)
+        .build();
+
+    Boolean b = simpleFlag.evaluate(user);
+
+    assertEquals(true, b);
+  }
+
+    @Test
+    public void testFlagForTargetBooleanTestOn() {
+        LDUser user = new LDUser.Builder("targetOther@test.com")
+                .custom("likes_cats", true)
+                .build();
+
+        Boolean b = simpleFlag.evaluate(user);
+
+        assertEquals(true, b);
+    }
+
   @Test
   public void testFlagForTargetGroupOff() {
     LDUser user = new LDUser.Builder("targetOther@test.com")
@@ -106,6 +141,28 @@ public void testFlagForTargetGroupOff() {
     assertEquals(false, b);
   }
 
+  @Test
+  public void testFlagForTargetNumericTestOff() {
+    LDUser user = new LDUser.Builder("targetOther@test.com")
+        .custom("favorite_number", 33.0)
+        .build();
+
+    Boolean b = simpleFlag.evaluate(user);
+
+    assertEquals(false, b);
+  }
+
+    @Test
+    public void testFlagForTargetBooleanTestOff() {
+        LDUser user = new LDUser.Builder("targetOther@test.com")
+                .custom("likes_dogs", false)
+                .build();
+
+        Boolean b = simpleFlag.evaluate(user);
+
+        assertEquals(false, b);
+    }
+
   @Test
   public void testDisabledFlagAlwaysOff() {
     LDUser user = new LDUser("targetOn@test.com");