From 016e463f9f52b218ba3ff2381369e4dffe2a055c Mon Sep 17 00:00:00 2001 From: Nathan Salazar Date: Wed, 8 Oct 2025 10:37:05 -0500 Subject: [PATCH 1/5] use is_a? method instead of implicitly relying on === because its definittion has changed --- lib/accessly/permission/grant.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/accessly/permission/grant.rb b/lib/accessly/permission/grant.rb index 530f620..2e7c9cf 100644 --- a/lib/accessly/permission/grant.rb +++ b/lib/accessly/permission/grant.rb @@ -8,9 +8,9 @@ class Grant < Accessly::Base # @param actor [ActiveRecord::Base] The actor to grant permission def initialize(actor) super(actor) - @actor = case actor - when ActiveRecord::Base - actor + + if actor.is_a?(ActiveRecord::Base) + @actor = actor else raise Accessly::GrantError.new("Actor is not an ActiveRecord::Base object") end From cf2e6414783187dcd251f09514135edb7fb82276 Mon Sep 17 00:00:00 2001 From: Nathan Salazar Date: Wed, 8 Oct 2025 11:20:32 -0500 Subject: [PATCH 2/5] try changing the list of ruby versions we test --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5a2adca..145a107 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,7 +19,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest] - ruby: ["2.6", "2.7", "3.0"] + ruby: ["2.7", "3.0", "3.1", "3.2"] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 From 9cd2fe1cea5af00b1efed5069026c29965e0d153 Mon Sep 17 00:00:00 2001 From: Nathan Salazar Date: Wed, 8 Oct 2025 11:26:07 -0500 Subject: [PATCH 3/5] update the database_cleaner gem --- .github/workflows/test.yml | 2 +- accessly.gemspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 145a107..5a2adca 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,7 +19,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest] - ruby: ["2.7", "3.0", "3.1", "3.2"] + ruby: ["2.6", "2.7", "3.0"] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 diff --git a/accessly.gemspec b/accessly.gemspec index 9052f1d..6d1bdb6 100644 --- a/accessly.gemspec +++ b/accessly.gemspec @@ -26,7 +26,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency "bundler", "~> 2.1" spec.add_development_dependency "rake", "~> 13.0" spec.add_development_dependency "minitest", "~> 5.0" - spec.add_development_dependency "database_cleaner", "~> 1.8" + spec.add_development_dependency "database_cleaner", "~> 2.0" spec.add_development_dependency "pg", "~> 1.0" spec.add_development_dependency "rails", ">= 5.0" end From 0eb9f0c4eeeb52a4894149205cb56b1ea692ad36 Mon Sep 17 00:00:00 2001 From: Nathan Salazar Date: Wed, 8 Oct 2025 11:31:09 -0500 Subject: [PATCH 4/5] stop supporting Ruby 2.6 --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5a2adca..145a107 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,7 +19,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest] - ruby: ["2.6", "2.7", "3.0"] + ruby: ["2.7", "3.0", "3.1", "3.2"] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 From 52840ffa1c403f0d9d8e48f0bf8ddcd5d2e2c40d Mon Sep 17 00:00:00 2001 From: Nathan Salazar Date: Wed, 8 Oct 2025 14:21:20 -0500 Subject: [PATCH 5/5] New commit to fix hanging test