-
Notifications
You must be signed in to change notification settings - Fork 43
Redundant isPeerId function #88
Copy link
Copy link
Open
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps uphelp wantedSeeking public contribution on this issueSeeking public contribution on this issuekind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featurestatus/readyReady to be workedReady to be worked
Description
Metadata
Metadata
Assignees
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps uphelp wantedSeeking public contribution on this issueSeeking public contribution on this issuekind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featurestatus/readyReady to be workedReady to be worked
After adding the
class-ismodule with js-peer-id#84, theisPeerIdfunction is redundant and can be removed js-peer-id/index.js#L291-L295.Note: this was not removed with the addition of
class-issince it is a breaking change and will need to change all its usages.