Enable VBA-M Game Boy Link as an Option

[Zombie-Ryushu]

VBA-M's module supports Game Boy Link in WX mode, but only in WX Mode. I think that you should Game Boy Link Mode as a Core Option under RetroArch, and use the underlying VBA-M code to accommodate this

thats kinda hard to do atm. even the standalone has its own problems with link and some games. but thats something that's thats gonna happen.

[Zombie-Ryushu]

This has been an issue for several years. Do you think going about this the TGB-DUAL Way is more feasible?
Game Link does work in TGB Dual, But it is only feasible in LAN settings, or Split screen?

Hi,

1°) VBA-M GBA Link code doesn't run correctly : they tried to use my code of my project VisualBoyAdvance Link project but they had applied it badly ^^"

However, I have successfully since several months an version of vbam-libretro that have my working code of GBA Link. I want just that you wait that I finish my updates of the source codes of Ludum. I will test my works on the latest vbam-libretro and tell you if it works.

2°) About Game Link on GB/GBC, I use my modified version of Gambatte that fixes Link issue on Linux and Windows. TGB Dual is Split screen ( the 2nd player receives the 2P screen from 1P computer ). Gambatte uses LAN settings.

[andres-asm]

The best way is the TGB/Sameboy way. A single libretro core that runs 2 instances of the emulator.
As far as I know VBA-M has far too much global state for that to be possible.

Regarding your changes, I think the intention here is to keep the core upstream friendly now, so changes must be agreable with upstream

I'm working on a netplay awareness callback that will allow the core to know it shouldn't display the second output and play the correct sound.

I got the GBA linking working successfully using the current code of libretro/vbam-libretro and little modifications :p Now I have on this core the LAN capacibility.

I have one question for you guys : I see on GBALink.cpp functions for GB Linking. How does it work ? Someone have tested it with wxvbam ?

Note for fr500 : TGB Dual is the bad way for me. Every user must have the capacibility to have his personnal save and personnal instance of the emulator. The "2 in 1 instances of the emulator" like TGB is the bad way...

So I checked the issues about Link GBA. And I see that --" . visualboyadvance-m/visualboyadvance-m#322 (comment)

So much optimism like always in VBA-M team members. So I will continue with my official method of GBA link that works on Windows and Linux computers. Gambatte will be perfect for GB/GBC link. VisualBoyAdvance Link, my project, will be perfect for fully functionnal GBA Linking. If people will be interested by VisualBoyAdvance Link, I will post you the project page.

[ZachBacon]

@JackoboLeChocobo as upstream project lead (sadly I wasn't the one that tried to merge your fork in at the time, funny enough back then I was merely a user), if there is anything you could suggest to improve, please let me know. I'd be happy and willing to land any improvements you think are needed.

I hope netplay support can be a possibility in the future.

Question : Where did it go ? https://github.com/visualboyadvance/vbam-libretro . I could access to it yesterday. Can someone confirm the death page on this link ? ( libretro/vbam-libretro was a fork of this project )

@ZachBacon, the solution is simple : as you can see, many people in your projects meets issues about Linking : I have tested too your project with the latest source code because the GB link feature didn't existed in the start of VBA Link. And after modifications on your codes, the client and server could see each other but in GB games, we can't launch a multiplayer game... Your current code of linking needs to be reseted from the start... But you said that "It's not overly a high priority item to fix" ... Some of your team members had used a part of my code but for the result you know today that...

For information, I have with the latest https://github.com/libretro/vbam-libretro code successfully restored my GBA linking functionnality with some features that are not present on the official code. So I don"t use SFML Library and Joybus and GB linking will not be here. BUT my GBA linking was tested and was approved since several years ago too by some people of the forums.

For now, because of some team members on some projects, I prefer keeping my fork, publish all in open source and write notes about my fixes, instead of sending patches to people on their projects and see that because I removed some functionalities that don't work, the patch will be refused. Like I said to Desmume team before about my Wifi code and many others projects like MPlayer for my DVD fix support, if you want to know how I did it, do like i did : research, tests and works.

If people want to test my works, I will be happy to send him my project page.

[ZachBacon]

@JackoboLeChocobo that's the old repo, I've been working with the libretro devs to use the proper upstream https://github.com/visualboyadvance-m/visualboyadvance-m
EDIT:
Also I'm open to anything, we already know that some things would need to refactor, it wasn't a high priority item due to the fact a lot of us on the team have left, It's myself and 2 other people that are doing our best to maintain the project.

@ZachBacon , Sorry if I was rude with you : It was my personnal experience that was talking when I contributed on some opensource projects :/

Do you prefer to continue the discussion here on an new ticket or on https://github.com/visualboyadvance-m/visualboyadvance-m with a new ticket ? I have some questions about the code. I will try to help you as much as possible. I will publish some news about what I have for the moment successfully done on your code and discuss about the actual code. We need to understand some datas and needs some tests/results.

I want to share that but I hesitate about the location of the new ticket. I will prepare before your answer the text.

[ZachBacon]

Go right ahead, I think it would be best since I think this repo either will be archived or removed and upstream recloned for better Pull Request management between downstream and upstream

@ZachBacon, so you want a new ticket on https://github.com/libretro/vbam-libretro/ if I understand ? Can you share me the Github names of the 2 other people who are with you on the project please ?

[ZachBacon]

@JackoboLeChocobo no on https://github.com/visualboyadvance-m/visualboyadvance-m/issues

@ZachBacon Okay thanks ^^