Skip to content

Commit 062719a

Browse files
Merge pull request #1064 from bryceosterhaus/master
fix(npm-scripts): temporary work around for grabbing rules config at both the root and module level
2 parents a6ad830 + 92591ce commit 062719a

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

projects/npm-tools/packages/npm-scripts/src/utils/collectDefinedDependencies.js

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,26 @@
33
* SPDX-License-Identifier: BSD-3-Clause
44
*/
55

6-
const getUserConfig = require('./getUserConfig');
6+
const path = require('path');
7+
8+
const findRoot = require('./findRoot');
79

810
function collectDefinedDependencies() {
9-
const rootConfig = getUserConfig('npmscripts');
11+
const rootDir = findRoot();
12+
13+
let rootConfig = {};
14+
15+
if (!rootDir) {
16+
return new Set();
17+
}
18+
19+
try {
20+
/* eslint-disable-next-line @liferay/no-dynamic-require */
21+
rootConfig = require(path.join(rootDir, 'npmscripts.config'));
22+
}
23+
catch (error) {
24+
return new Set();
25+
}
1026

1127
const amdImports = new Set(
1228
Object.entries(rootConfig.build.bundler.config.imports).reduce(

projects/npm-tools/packages/npm-scripts/src/utils/getMergedConfig.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,10 @@ function getMergedConfig(type, property) {
201201
mergedConfig = deepMerge(
202202
[
203203
require('../config/npmscripts.config'),
204+
205+
// Temporary workaround until we re-evaluate global key
206+
207+
{rules: rootConfig.global?.rules || {}},
204208
rootConfig,
205209
getUserConfig('npmscripts'),
206210
],

0 commit comments

Comments
 (0)