Skip to content

Commit 06e047c

Browse files
authored
Merge pull request #154 from liferay/wincent/scope/npm-bundler
chore(js-toolkit): move liferay-npm-bundler (v3.x) to @liferay/npm-bundler
2 parents 0aaacc4 + 0eb88ce commit 06e047c

File tree

54 files changed

+27
-23
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+27
-23
lines changed

projects/js-toolkit/CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions

projects/js-toolkit/packages/generator-js/src/adapt/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,8 +291,8 @@ export default class extends Generator {
291291
getSDKVersion('liferay-npm-build-support', {ignoreConfig: true})
292292
);
293293
pkgJson.addDevDependency(
294-
'liferay-npm-bundler',
295-
getSDKVersion('liferay-npm-bundler', {ignoreConfig: true})
294+
'@liferay/npm-bundler',
295+
getSDKVersion('@liferay/npm-bundler', {ignoreConfig: true})
296296
);
297297
pkgJson.addDevDependency(
298298
`liferay-npm-bundler-preset-${preset}`,

projects/js-toolkit/packages/generator-js/src/facet-project/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ export default class extends Generator {
4949
const cp = new Copier(this);
5050

5151
const context = {
52-
liferayNpmBuildSupportVersion: getSDKVersion('liferay-npm-bundler'),
52+
liferayNpmBuildSupportVersion: getSDKVersion(
53+
'@liferay/npm-bundler'
54+
),
5355
liferayNpmBundlerVersion: getSDKVersion(
5456
'liferay-npm-build-support'
5557
),

projects/js-toolkit/packages/generator-js/src/facet-project/templates/package.json.ejs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "1.0.0",
44
"description": "<%= description %>",
55
"devDependencies": {
6-
"liferay-npm-bundler": "<%= liferayNpmBundlerVersion %>",
6+
"@liferay/npm-bundler": "<%= liferayNpmBundlerVersion %>",
77
"liferay-npm-build-support": "<%= liferayNpmBuildSupportVersion %>"
88
},
99
"dependencies": {},

projects/js-toolkit/packages/js-toolkit-core/src/project/Probe.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ export default class Probe {
4242
return ProjectType.LIFERAY_FRAGMENT;
4343
}
4444

45-
// This must go last, as all other types have liferay-npm-bundler as
46-
// dependency
45+
// This must go last, as all other types have (or may have)
46+
// @liferay/npm-bundler as dependency.
4747

4848
if (
49-
this._hasDependency('liferay-npm-bundler') ||
49+
this._hasDependency('@liferay/npm-bundler') ||
5050
this._hasDependency('@liferay/js-toolkit-scripts') ||
5151
this._hasScriptCalling('js-toolkit')
5252
) {

projects/js-toolkit/packages/js-toolkit-core/src/project/Project.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ export default class Project {
330330

331331
// Get bundler and me versions
332332

333-
putInMap('liferay-npm-bundler');
333+
putInMap('@liferay/npm-bundler');
334334
putInMap(path.join(__dirname, '../..'));
335335

336336
// Get preset version

projects/js-toolkit/packages/js-toolkit-core/src/project/__tests__/Project.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -372,9 +372,9 @@ describe('project.versionsInfo', () => {
372372
},
373373
],
374374
[
375-
'liferay-npm-bundler',
375+
'@liferay/npm-bundler',
376376
{
377-
version: require(`../../../../../../../node_modules/liferay-npm-bundler/package.json`)
377+
version: require(`../../../../../../../node_modules/@liferay/npm-bundler/package.json`)
378378
.version,
379379
path: path.join(
380380
'..',
@@ -388,7 +388,8 @@ describe('project.versionsInfo', () => {
388388
'..',
389389
'..',
390390
'node_modules',
391-
'liferay-npm-bundler'
391+
'@liferay',
392+
'npm-bundler'
392393
),
393394
},
394395
],

projects/js-toolkit/packages/js-toolkit-scripts/src/scripts/create-jar/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ function addLocalizationFiles(zip: JSZip): void {
116116
function addManifest(zip: JSZip): void {
117117
let contents = '';
118118

119-
const bundlerVersion = project.versionsInfo.get('liferay-npm-bundler')
119+
const bundlerVersion = project.versionsInfo.get('@liferay/npm-bundler')
120120
.version;
121121

122122
contents += `Manifest-Version: 1.0\n`;

projects/js-toolkit/packages/liferay-npm-bundler/.yarnrc

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Make `yarn version` produce the right commit message and tag for this package.
2+
version-tag-prefix "npm-bundler/v"
3+
version-git-message "chore: prepare @liferay/npm-bundler v%s release"

0 commit comments

Comments
 (0)