go.mod: bump lnd@v0.20.0-beta; bump lndclient@v0.20.0-5

[ffranr]

Goal: bump LND to a non RC version so the next non RC tap release can ship in the next non RC litd release.

Run commands:

go get github.com/lightningnetwork/lnd@v0.20.0-beta
go get github.com/lightninglabs/lndclient@v0.20.0-5
go mod tidy

[gemini-code-assist]

Summary of Changes

Hello @ffranr, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating core dependencies to prepare for the next stable release. It primarily bumps the lnd and lndclient versions to their latest non-RC betas and addresses a critical compatibility issue by adjusting the lightning-onion dependency. Additionally, a minor code change was necessary to align with the updated LND API, ensuring smooth integration and functionality.

Highlights

• Dependency Updates: The lnd dependency has been updated to v0.19.3-beta and lndclient to v0.19.3-0 to align with a non-release candidate version of LND.
• Compatibility Fix: The lightning-onion dependency has been adjusted to a specific older version (v1.2.1-0.20240712235311-98bd56499dfb) to resolve a compatibility issue with the updated LND.
• API Alignment: The chainntnfs.ConfirmationEvent structure in lndservices/daemon_adapters.go has been modified to update the type of its Updates channel from chainntnfs.TxUpdateInfo to uint32 for compatibility with the new LND API.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the LND dependencies to a non-RC version, which aligns with the stated goal. The accompanying code change in lndservices/daemon_adapters.go addresses a compatibility issue introduced by the dependency bump. However, I've identified a high-severity issue in lndservices/daemon_adapters.go where several notification channels are created but never populated, potentially leading to deadlocks for consumers of this function. Additionally, error conditions like transaction re-orgs are not handled because a crucial error channel is ignored. I've provided a review comment with a suggestion to mitigate the immediate deadlock risk.

[coveralls]

Pull Request Test Coverage Report for Build 19334873869

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 52 unchanged lines in 10 files lost coverage.
• Overall coverage increased (+0.05%) to 56.427%

---

Files with Coverage Reduction	New Missed Lines	%
asset/asset.go	2	80.3%
tapgarden/custodian.go	2	76.83%
universe/archive.go	2	79.91%
commitment/tap.go	3	85.19%
itest/multisig.go	3	97.52%
mssmt/compacted_tree.go	4	78.11%
tapdb/interfaces.go	6	82.5%
universe/syncer.go	6	84.65%
tapdb/multiverse.go	8	79.52%
address/mock.go	16	87.5%

Totals
Change from base Build 19332157089:	0.05%
Covered Lines:	64002
Relevant Lines:	113424

---

💛 - Coveralls

[jtobin]

Nice one. 👍 👍

This looks good to me. The LiT tests in CI appear to be complaining solely due to the lightning-onion downgrade.

Gemini is also complaining about something in daemon_adapters.go, but it doesn't look to be related to your change, and without more context from Gemini I have to assume it's a false positive.

[ffranr]

Before merge, I'll take a look at the lit CI fail.
EDIT: We may hold off on merging this if we decide to wait for the upcoming LND release. I've converted to draft to avoid accidental merge.

[ffranr]

I'm going to re-use this PR to bump to LND v0.20.0 instead. I'll re-request reviews.