Replace 32 with BitsSize in Bit<T> methods #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Solution Summary
This PR fixes issue #106 by replacing hardcoded
32values with theBitsSizefield in theBit<T>class methods.📋 Issue Reference
Fixes #106
🔧 Changes Made
csharp/Platform.Numbers/Bit[T].csPartialWrite- Lines 29 and 33shift = 32 + shift;toshift = BitsSize + shift;limit = 32 + limit;tolimit = BitsSize + limit;PartialRead- Lines 43 and 47shift = 32 + shift;toshift = BitsSize + shift;limit = 32 + limit;tolimit = BitsSize + limit;✅ Verification
📖 Technical Details
The
BitsSizefield is already defined in the class as:This change makes the bit operations generic and work correctly for different numeric types (not just 32-bit integers), which aligns with the generic nature of the
Bit<T>class.🧪 Test Results
🤖 This solution was implemented automatically by the AI issue solver