progress

Author: lgarber-akamai

linode_api4/objects/networking.py

@@ -176,6 +176,7 @@ class VLAN(Base):
     }
 
 
+@dataclass
 class FirewallCreateDevicesOptions(JSONObject):
     """
     Represents devices to create created alongside a Linode Firewall.
@@ -186,6 +187,7 @@ class FirewallCreateDevicesOptions(JSONObject):
     interfaces: List[int] = field(default_factory=list)
 
 
+@dataclass
 class FirewallSettingsDefaultFirewallIDs(JSONObject):
     """
     Contains the IDs of Linode Firewalls that should be used by default
@@ -207,8 +209,8 @@ class FirewallSettings(Base):
 
     api_endpoint = "/networking/firewalls/settings"
 
-    # NOTE: This isn't used but is necessary when deriving from Base
-    id_attributes = "default_firewall_ids"
+    # # NOTE: This isn't used but is necessary when deriving from Base
+    # id_attributes = "default_firewall_ids"
 
     properties = {
         "default_firewall_ids": Property(

test/fixtures/networking_firewalls_123_devices.json

@@ -25,5 +25,5 @@
   ],
   "page": 1,
   "pages": 1,
-  "results": 1
+  "results": 2
 }

test/unit/linode_client_test.py

@@ -1,7 +1,7 @@
 from datetime import datetime
 from test.unit.base import ClientBaseCase
 
-from linode_api4 import LongviewSubscription
+from linode_api4 import FirewallCreateDevicesOptions, LongviewSubscription
 from linode_api4.objects.beta import BetaProgram
 from linode_api4.objects.linode import Instance
 from linode_api4.objects.networking import IPAddress
@@ -63,12 +63,18 @@ def test_get_regions(self):
                         "NodeBalancers",
                         "Block Storage",
                         "Object Storage",
+                        "Enhanced Interfaces",
                     ],
                 )
             else:
                 self.assertEqual(
                     region.capabilities,
-                    ["Linodes", "NodeBalancers", "Block Storage"],
+                    [
+                        "Linodes",
+                        "NodeBalancers",
+                        "Block Storage",
+                        "Enhanced Interfaces",
+                    ],
                 )
             self.assertEqual(region.status, "ok")
             self.assertIsNotNone(region.resolvers)
@@ -1187,7 +1193,7 @@ def test_firewall_create(self):
             f = self.client.networking.firewall_create(
                 "test-firewall-1",
                 rules,
-                devices=FirewallDevicesOptions(
+                devices=FirewallCreateDevicesOptions(
                     linodes=[123], nodebalancers=[456], interfaces=[789]
                 ),
                 status="enabled",
@@ -1208,7 +1214,7 @@ def test_firewall_create(self):
                     "devices": {
                         "linodes": [123],
                         "nodebalancers": [456],
-                        "interface": [789],
+                        "interfaces": [789],
                     },
                 },
             )

test/unit/objects/firewall_test.py

@@ -61,11 +61,11 @@ def test_create_device(self):
 
         firewall = Firewall(self.client, 123)
 
-        with self.mock_post("networking/firewalls/123/devices") as m:
+        with self.mock_post("networking/firewalls/123/devices/123") as m:
             firewall.device_create(123, "linode")
             assert m.call_data == {"id": 123, "type": "linode"}
 
-        with self.mock_post("networking/firewalls/123/devices") as m:
+        with self.mock_post("networking/firewalls/123/devices/456") as m:
             firewall.device_create(123, "interface")
             assert m.call_data == {"id": 123, "type": "interface"}