Skip to content

Commit 356e7ba

Browse files
committed
improve slack test notification
1 parent 02256ba commit 356e7ba

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

.github/workflows/e2e-test.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
run: |
9292
timestamp=$(date +'%Y%m%d%H%M')
9393
report_filename="${timestamp}_sdk_test_report.xml"
94-
make test-int RUN_DB_FORK_TESTS=${{ github.event.inputs.run_db_fork_tests }} RUN_DB_TESTS=${{ github.event.inputs.run_db_tests }} TEST_SUITE="domain" TEST_ARGS="--junitxml=${report_filename}"
94+
make test-int RUN_DB_FORK_TESTS=${{ github.event.inputs.run_db_fork_tests }} RUN_DB_TESTS=${{ github.event.inputs.run_db_tests }} TEST_SUITE="${{ github.event.inputs.test_suite }}" TEST_ARGS="--junitxml=${report_filename}"
9595
env:
9696
LINODE_TOKEN: ${{ env.LINODE_TOKEN }}
9797

@@ -172,7 +172,7 @@ jobs:
172172
process-upload-report:
173173
runs-on: ubuntu-latest
174174
needs: [integration-tests]
175-
if: always() #&& github.repository == 'linode/linode_api4-python' # Run even if integration tests fail and only on main repository
175+
if: always() && github.repository == 'linode/linode_api4-python' # Run even if integration tests fail and only on main repository
176176
outputs:
177177
summary: ${{ steps.set-test-summary.outputs.summary }}
178178

@@ -262,9 +262,6 @@ jobs:
262262
- type: mrkdwn
263263
text: "Triggered by: :bust_in_silhouette: `${{ github.actor }}`"
264264
265-
- name: Debug Test Summary
266-
run: echo "${{ needs.process-upload-report.outputs.summary }}"
267-
268265
- name: Test summary thread
269266
if: success()
270267
uses: slackapi/slack-github-action@v2.0.0

test/integration/models/domain/test_domain.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def test_get_domain_record(test_linode_client, test_domain):
1313
test_linode_client, test_domain.records.first().id, test_domain.id
1414
)
1515

16-
assert False
16+
assert dr.id == test_domain.records.first().id
1717

1818

1919
def test_save_null_values_excluded(test_linode_client, test_domain):
@@ -23,7 +23,7 @@ def test_save_null_values_excluded(test_linode_client, test_domain):
2323
domain.master_ips = ["127.0.0.1"]
2424
res = domain.save()
2525

26-
assert False
26+
assert res
2727

2828

2929
def test_zone_file_view(test_linode_client, test_domain):

0 commit comments

Comments
 (0)