progress

Author: lgarber-akamai

linode_api4/groups/networking.py

@@ -1,16 +1,21 @@
+from typing import Any, Dict, Optional, Union
+
 from linode_api4.errors import UnexpectedResponseError
 from linode_api4.groups import Group
 from linode_api4.objects import (
     VLAN,
     Base,
     Firewall,
+    FirewallCreateDevicesOptions,
     Instance,
     IPAddress,
     IPv6Pool,
     IPv6Range,
     NetworkTransferPrice,
     Region,
 )
+from linode_api4.objects.base import _flatten_request_body_recursive
+from linode_api4.util import drop_null_keys
 
 
 class NetworkingGroup(Group):
@@ -33,7 +38,13 @@ def firewalls(self, *filters):
         """
         return self.client._get_and_filter(Firewall, *filters)
 
-    def firewall_create(self, label, rules, **kwargs):
+    def firewall_create(
+        self,
+        label: str,
+        rules: Dict[str, Any],
+        devices: Optional[Union[FirewallCreateDevicesOptions, Dict[str, Any]]],
+        **kwargs,
+    ):
         """
         Creates a new Firewall, either in the given Region or
         attached to the given Instance.
@@ -44,6 +55,8 @@ def firewall_create(self, label, rules, **kwargs):
         :type label: str
         :param rules: The rules to apply to the new Firewall. For more information on Firewall rules, see our `Firewalls Documentation`_.
         :type rules: dict
+        :param devices: Represents devices to create created alongside a Linode Firewall.
+        :type devices: Optional[Union[FirewallCreateDevicesOptions, Dict[str, Any]]]
 
         :returns: The new Firewall.
         :rtype: Firewall
@@ -81,10 +94,14 @@ def firewall_create(self, label, rules, **kwargs):
         params = {
             "label": label,
             "rules": rules,
+            "devices": devices,
         }
         params.update(kwargs)
 
-        result = self.client.post("/networking/firewalls", data=params)
+        result = self.client.post(
+            "/networking/firewalls",
+            data=drop_null_keys(_flatten_request_body_recursive(params)),
+        )
 
         if not "id" in result:
             raise UnexpectedResponseError(

linode_api4/objects/networking.py

@@ -1,5 +1,5 @@
-from dataclasses import dataclass
-from typing import Optional
+from dataclasses import dataclass, field
+from typing import List, Optional
 
 from linode_api4.common import Price, RegionPrice
 from linode_api4.errors import UnexpectedResponseError
@@ -176,6 +176,16 @@ class VLAN(Base):
     }
 
 
+class FirewallCreateDevicesOptions(JSONObject):
+    """
+    Represents devices to create created alongside a Linode Firewall.
+    """
+
+    linodes: List[int] = field(default_factory=list)
+    nodebalancers: List[int] = field(default_factory=list)
+    interfaces: List[int] = field(default_factory=list)
+
+
 class FirewallDevice(DerivedBase):
     """
     An object representing the assignment between a Linode Firewall and another Linode resource.