Fix interfaces settings

Author: lgarber-akamai

linode_api4/linode_client.py

@@ -283,6 +283,10 @@ def _api_call(
             verify=self.ca_path or self.session.verify,
         )
 
+        print(
+            "\nNEW REQUEST:\n", method, url, "\n", body, "\n", response.json()
+        )
+
         warning = response.headers.get("Warning", None)
         if warning:
             logger.warning("Received warning from server: {}".format(warning))

linode_api4/objects/base.py

@@ -239,6 +239,7 @@ def __setattr__(self, name, value):
         """
         Enforces allowing editing of only Properties defined as mutable
         """
+
         if name in type(self).properties.keys():
             if not type(self).properties[name].mutable:
                 raise AttributeError(

linode_api4/objects/linode.py

@@ -1940,24 +1940,26 @@ def interface_create(
         return LinodeInterface(self._client, result["id"], self.id, json=result)
 
     @property
-    def interfaces_settings(self):
+    def interfaces_settings(self) -> LinodeInterfacesSettings:
+        """
+        The settings for all interfaces under this Linode.
+
+        :returns: The settings for instance-level interface settings for this Linode.
+        """
 
         # NOTE: We do not implement this as a Property because Property does
         # not currently have a mechanism for 1:1 sub-entities.
-        result = self._client.get(
-            "{}/interfaces/settings".format(Instance.api_endpoint), model=self
-        )
 
-        if not "network_helper" in result:
-            raise UnexpectedResponseError(
-                "Unexpected response when getting settings for Linode interfaces!",
-                json=result,
+        if not hasattr(self, "_interfaces_settings"):
+            self._set(
+                "_interfaces_settings",
+                # We don't use lazy loading here because it can trigger a known issue
+                # where setting fields for updates before the entity has been lazy loaded
+                # causes the user's value to be discarded.
+                self._client.load(LinodeInterfacesSettings, self.id),
             )
 
-        # TODO (Enhanced Interfaces): Error handling for Linodes using legacy interfaces?
-
-        s = LinodeInterfacesSettings(self._client, self.id, result)
-        return s
+        return self._interfaces_settings
 
     @property
     def interfaces(self):

linode_api4/objects/linode_interfaces.py

@@ -32,8 +32,8 @@ class LinodeInterfacesSettingsDefaultRoute(JSONObject):
 
 
 class LinodeInterfacesSettings(Base):
-    """ "
-    The settings for a Linode's network interfaces.
+    """
+    The settings related to a Linode's network interfaces.
 
     API Documentation: Not yet available.
     """

test/unit/objects/linode_test.py

@@ -518,6 +518,8 @@ def test_update_interfaces_settings(self):
         iface_settings.default_route.ipv4_interface_id = 456
         iface_settings.default_route.ipv6_interface_id = 123
 
+        print(vars(iface_settings))
+
         with self.mock_put("/linode/instances/124/interfaces/settings") as m:
             iface_settings.save()