Skip to content

Commit 96edcc3

Browse files
Updated get_rule_versions to be a property method
1 parent e45ab24 commit 96edcc3

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

linode_api4/objects/networking.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,8 @@ def get_rules(self):
244244
"{}/rules".format(self.api_endpoint), model=self
245245
)
246246

247-
def get_rule_versions(self):
247+
@property
248+
def rule_versions(self):
248249
"""
249250
Gets the JSON rule versions for this Firewall.
250251

test/integration/models/networking/test_networking.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def test_get_networking_rule_versions(test_linode_client, test_firewall):
9898
firewall.update_rules(new_rules)
9999
time.sleep(1)
100100

101-
rule_versions = firewall.get_rule_versions()
101+
rule_versions = firewall.rule_versions
102102

103103
# Original firewall rules
104104
old_rule_version = firewall.get_rule_version(1)

test/unit/objects/networking_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def test_get_rule_versions(self):
5555
firewall = Firewall(self.client, 123)
5656

5757
with self.mock_get("/networking/firewalls/123/history") as m:
58-
result = firewall.get_rule_versions()
58+
result = firewall.rule_versions
5959
self.assertEqual(m.call_url, "/networking/firewalls/123/history")
6060
self.assertEqual(result["data"][0]["status"], "enabled")
6161
self.assertEqual(result["data"][0]["rules"]["version"], 1)

0 commit comments

Comments
 (0)