- 
                Notifications
    
You must be signed in to change notification settings  - Fork 78
 
Python SDK for ACLP Alerts #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            srbhaakamai
  wants to merge
  102
  commits into
  linode:dev
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
srbhaakamai:dev
  
      
      
   
  
    
  
  
  
 
  
      
    base: dev
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from 92 commits
      Commits
    
    
            Show all changes
          
          
            102 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      66327ec
              
                DI-26927 Python SDK code for GET Alert Definitions
              
              
                srbhaakamai b94544c
              
                DI-26927 Python SDK code modified for client code
              
              
                srbhaakamai ba218c8
              
                DI-26927 Added Unit test cases and missing classes
              
              
                srbhaakamai 1c4d705
              
                DI-26927 made corrections to keep code consistent
              
              
                srbhaakamai cc91d56
              
                DI-26927 Updated Unit and Integratoion Tests
              
              
                srbhaakamai d74bdcd
              
                [dev 51950af] DI-26927 Updated Unit and Integratoion Tests
              
              
                srbhaakamai a279a5a
              
                Revert "DI-26927 Updated Unit and Integratoion Tests"
              
              
                srbhaakamai 7f0bf2d
              
                Revert "[dev 51950af] DI-26927 Updated Unit and Integratoion Tests"
              
              
                srbhaakamai 9f631b1
              
                DI-26927 Updated Unit and Integratoion Tests
              
              
                srbhaakamai 04f2c1c
              
                Remove .venv from repo and add to .gitignore
              
              
                srbhaakamai e499726
              
                DI-26927 reverted git ignore
              
              
                srbhaakamai c30c97f
              
                DI-26927 reverted conftest,py
              
              
                srbhaakamai 762d49c
              
                DI-26927  added accidentlly deleted file
              
              
                srbhaakamai 1c4fd7e
              
                DI-26927 Corrected Integration and Unit Test cases for Alerting APIs
              
              
                srbhaakamai 39e9f41
              
                DI-26927 Reverted conftest.py and check integration without those cha…
              
              
                srbhaakamai c8e8961
              
                DI-26927 fixed integration test for firewall and added time for alert…
              
              
                srbhaakamai 9a97568
              
                DI-26927 fixed changing monitor.py as per review comments
              
              
                srbhaakamai 12491b6
              
                DI-26927 fixed changing monitor.py as per review comments
              
              
                srbhaakamai d67d284
              
                DI-26927 fixed changing monitor.py as per review comments
              
              
                srbhaakamai c04d801
              
                DI-26927 Intermediate change to address internal review comments
              
              
                srbhaakamai a735230
              
                DI-26927 CLosed review comments
              
              
                srbhaakamai 03fe6b1
              
                DI-26927 CLosed review comments
              
              
                srbhaakamai a938d35
              
                DI-27156 closed review comments from Ketan
              
              
                srbhaakamai 13a188b
              
                DI-27156 closed review comments from Ketan
              
              
                srbhaakamai e10da0c
              
                DI-27156 fixed unit test cases post review comments fixes
              
              
                srbhaakamai 8bec096
              
                DI-27156 Updated docstring and make unit test cases changes
              
              
                srbhaakamai 9f5ed8a
              
                DI-27156 Added unit test cases post review comments fixes
              
              
                srbhaakamai a0d6afc
              
                DI-27156 Added unit test cases post review comments fixes
              
              
                srbhaakamai 0ea9aeb
              
                tests(monitor): add MonitorAlertDefinitionsTest and update fixtures f…
              
              
                srbhaakamai 0774dcc
              
                DI-27156 Added unit test cases post review comments fixes
              
              
                srbhaakamai cfd02d5
              
                DI-27156 Updated docstring
              
              
                srbhaakamai 16d17f3
              
                DI-27156 Updated unit test errors
              
              
                srbhaakamai 47a6e25
              
                removed unwanted files
              
              
                srbhaakamai 400eb0a
              
                added missing doxcstring
              
              
                srbhaakamai 4584ea4
              
                added missing doxcstring
              
              
                srbhaakamai c5e8491
              
                added missing doxcstring
              
              
                srbhaakamai c4c4490
              
                rmoved test files
              
              
                srbhaakamai 06bd0ce
              
                closed final review comments
              
              
                srbhaakamai fcd4d2d
              
                fixing integration test issues
              
              
                srbhaakamai c8ddabd
              
                Corrected Integration Test Case
              
              
                srbhaakamai 71c5b30
              
                DI-26927 Corrected json to object modifications issues
              
              
                srbhaakamai a5e81cc
              
                DI-26927 Corrected json to object modifications issues
              
              
                srbhaakamai a2e73fd
              
                DI-26927 Unit test corrections for mofied functions name
              
              
                srbhaakamai 3252718
              
                Delete test/fixtures/monitor/services/dbaas/alert-definitions.json
              
              
                srbhaakamai 261686f
              
                Delete test.py
              
              
                srbhaakamai f3b50f3
              
                Delete test/fixtures/monitor/alert-definitions.json
              
              
                srbhaakamai 5f08522
              
                DI-26927 reverted fixtures.py as its not necesary to change
              
              
                srbhaakamai f9052de
              
                DI-26927 reverted fixtures.py as its not necesary to change
              
              
                srbhaakamai aabf3f1
              
                DI-26927 reverted fixtures.py as its not necesary to change
              
              
                srbhaakamai 68468b3
              
                DI-26927 fixed linting error
              
              
                srbhaakamai 26b79a7
              
                DI-26927 fixed linting error
              
              
                srbhaakamai 0dd18d6
              
                DI-26927 fixed lint error caught in CI
              
              
                srbhaakamai 54b8ab1
              
                Update test/unit/groups/monitor_api_test.py
              
              
                srbhaakamai 752936d
              
                Update test/integration/models/monitor/test_monitor.py
              
              
                srbhaakamai c2690a6
              
                Update test/integration/models/monitor/test_monitor.py
              
              
                srbhaakamai fb9e4bd
              
                Update test/integration/models/monitor/test_monitor.py
              
              
                srbhaakamai d3a7c2d
              
                Update linode_api4/objects/monitor.py
              
              
                srbhaakamai 8558a57
              
                DI-26927 fixed copilot comments
              
              
                srbhaakamai bb2a05e
              
                fixed review comments from APIv4 team
              
              
                srbhaakamai a9554f9
              
                fixed review comments from APIv4 team
              
              
                srbhaakamai 76606d1
              
                fixed review comments from APIv4 team
              
              
                srbhaakamai 6d6a9a5
              
                fixed review comments from APIv4 team
              
              
                srbhaakamai 52f6e20
              
                DI-26927 fixed review comments from API v4 team
              
              
                srbhaakamai efdbea8
              
                fixed review comments from APIv4 team
              
              
                srbhaakamai 0ea97d6
              
                fixed lint errors
              
              
                srbhaakamai 0ab0687
              
                Update linode_api4/groups/monitor.py
              
              
                srbhaakamai a91f384
              
                Update linode_api4/groups/monitor.py
              
              
                srbhaakamai 86782a8
              
                fixed review  errors
              
              
                srbhaakamai 9775ab2
              
                fixed unittest
              
              
                srbhaakamai c39a19d
              
                fixed unittest
              
              
                srbhaakamai d327b02
              
                fixed unittest
              
              
                srbhaakamai 4e1384e
              
                fixed unittest
              
              
                srbhaakamai e71320d
              
                fixed unittest
              
              
                srbhaakamai cabde89
              
                fixed unittest
              
              
                srbhaakamai bb157b7
              
                added update use case to integration test
              
              
                srbhaakamai 4f1c7db
              
                Merge branch 'linode:dev' into dev
              
              
                srbhaakamai b4e2128
              
                Update linode_api4/objects/monitor.py
              
              
                srbhaakamai 7550bb4
              
                Update linode_api4/objects/monitor.py
              
              
                srbhaakamai 559e9e7
              
                Update linode_api4/objects/monitor.py
              
              
                srbhaakamai f1861cd
              
                Update linode_api4/objects/monitor.py
              
              
                srbhaakamai b626bf9
              
                fixed further review comments
              
              
                srbhaakamai e459ac8
              
                Updated  integration test
              
              
                srbhaakamai e595a72
              
                Updated  integration test with more assert statements
              
              
                srbhaakamai 4132d1b
              
                Fix Linode interfaces property (#604)
              
              
                srbhaakamai ce9ad27
              
                Fix test for interfaces (#605)
              
              
                srbhaakamai d2a519d
              
                Fix test
              
              
                srbhaakamai f5503a4
              
                changed as per github-advanced-security comments
              
              
                srbhaakamai 31198da
              
                fixed formatting errors using python black
              
              
                srbhaakamai 7d1dd7e
              
                Migrate test fixtures discovery to be with pathlib (#599)
              
              
                srbhaakamai e8c35d1
              
                Merge branch 'linode:dev' into dev
              
              
                srbhaakamai 23c4071
              
                Update linode_api4/objects/monitor.py
              
              
                srbhaakamai d90f992
              
                Merge branch 'dev' into dev
              
              
                zliang-akamai df6370f
              
                Fixed Copilot comments on unit and integration tests
              
              
                srbhaakamai 5694f6e
              
                corrected unit test assert statement
              
              
                srbhaakamai 0864866
              
                Added comment as per copilot suggestion for save() and delete()
              
              
                srbhaakamai 5c35c8a
              
                resolved comments from copilot commented whereever not applicable
              
              
                srbhaakamai 205ed92
              
                Merge branch 'dev' into dev
              
              
                srbhaakamai 1bdde74
              
                Test: verify automatic GPG signing is working
              
              
                srbhaakamai 8961668
              
                Incorporated copilot comments
              
              
                srbhaakamai a4f3d37
              
                Removed serialisabel file from commit
              
              
                srbhaakamai 9725879
              
                Fix Lint errors
              
              
                srbhaakamai 4939068
              
                fixed review comments fo mutable
              
              
                srbhaakamai File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.