Skip to content

Conversation

@zliang-akamai
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 30, 2025 00:39
@zliang-akamai zliang-akamai requested a review from a team as a code owner October 30, 2025 00:39
@zliang-akamai zliang-akamai added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Oct 30, 2025
@zliang-akamai zliang-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team October 30, 2025 00:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new GitHub labels to help manage issue lifecycle and prevent automatic closure by stale bots.

  • Adds a "keep" label to prevent GitHub from automatically closing issues
  • Adds a "stale" label to indicate issues that will be closed soon by automation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

zliang-akamai and others added 4 commits October 29, 2025 20:45
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Rules FirewallRuleSet `json:"rules"`
Tags []string `json:"tags,omitempty"`
Devices DevicesCreationOptions `json:"devices,omitempty"`
Devices DevicesCreationOptions `json:"devices,omitzero"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a behavior change, that when Devices is not included when defining an instance of FirewallCreateOptions, it will change from an empty map to omitted from request body.

r, e := json.Marshal(linodego.FirewallCreateOptions{})
if e != nil {
	log.Fatal(e)
}
fmt.Println(string(r))

Original behavior:

{"rules":{"inbound":null,"inbound_policy":"","outbound":null,"outbound_policy":""},"devices":{}}

Updated behavior:

{"rules":{"inbound":null,"inbound_policy":"","outbound":null,"outbound_policy":""}}

I can't think of any actual effect on the API call except this body change, so I don't think this is a breaking change. But let me know if you think about it differently.

@zliang-akamai zliang-akamai changed the title Add keep and stale label Add keep and stale label; fix lint Oct 30, 2025
@lgarber-akamai
Copy link
Contributor

@zliang-akamai Per our conversation in Slack, do you think it'd make sense to get rid of the stale workflow altogether in this PR?

@zliang-akamai
Copy link
Member Author

@lgarber-akamai done, thanks!

@zliang-akamai zliang-akamai changed the title Add keep and stale label; fix lint Remove stale workflow; fix lint Oct 30, 2025
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling this!

@ezilber-akamai ezilber-akamai merged commit fec54e0 into main Nov 5, 2025
10 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/keep-label branch November 6, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repo-ci-improvement for improvements in the repository or CI workflow in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants