[Framework] Battery care support for Framework A5 Laptop 13 (AMD Ryzen 7040 Series) not loaded - BIOS 3.09 needs a patch expected with Linux 6.17

[BarbUk]

[x] I've read and accepted the Bug Reporting Howto
[x] I've provided all required tlp-stat outputs via Gist (see below)

Describe the bug

Following #765:

• cros_charge-control is loaded

$ modinfo cros_charge-control
filename:       /lib/modules/6.15.4-4-cachyos/kernel/drivers/power/supply/cros_charge-control.ko.zst
license:        GPL
author:         Thomas Weißschuh <linux@weissschuh.net>
description:    ChromeOS EC charge control
srcversion:     058B681F79D9FB098B3EDBF
alias:          platform:cros-charge-control
depends:        
intree:         Y
name:           cros_charge_control
retpoline:      Y
vermagic:       6.15.4-4-cachyos SMP preempt mod_unload 

• battery care plugin shows as:

Plugin: generic
Supported features: none available

Expected behavior

Plugin: cros-ec should be loaded ?

To Reproduce

1. Does the problem occur on battery or AC or both?

Both

Stats

tlp-stat -v -s -b

tlp-stat on AC

tlp-stat on BAT

dmi

$ grep . /sys/class/dmi/id/*
/sys/class/dmi/id/bios_date:04/22/2025
/sys/class/dmi/id/bios_release:3.9
/sys/class/dmi/id/bios_vendor:INSYDE Corp.
/sys/class/dmi/id/bios_version:03.09
/sys/class/dmi/id/board_asset_tag:*
/sys/class/dmi/id/board_name:FRANMDCP05
/sys/class/dmi/id/board_vendor:Framework
/sys/class/dmi/id/board_version:A5
/sys/class/dmi/id/chassis_asset_tag:FRANDRCPA552350019
/sys/class/dmi/id/chassis_type:10
/sys/class/dmi/id/chassis_vendor:Framework
/sys/class/dmi/id/chassis_version:A5
/sys/class/dmi/id/product_family:Laptop
/sys/class/dmi/id/product_name:Laptop 13 (AMD Ryzen 7040Series)
/sys/class/dmi/id/product_sku:FRANDRCP05
/sys/class/dmi/id/product_version:A5
/sys/class/dmi/id/sys_vendor:Framework

[linrunner]

Hi. modinfo does not prove that the module is loaded.

On the contrary

/sys/class/power_supply/BAT1/charge_control_start_threshold = (not available)
/sys/class/power_supply/BAT1/charge_control_end_threshold = (not available)
/sys/class/power_supply/BAT1/charge_behaviour = (not available)

shows that something must have gone wrong on the kernel or module side. Otherwise these sysfiles would be there. The cause of the problem does not lie within TLP.

Please show:

sudo modprobe -v cros_charge-control
ls -l /sys/bus/platform/devices/cros*
dmesg | grep cros

[BarbUk]

Hi,

Thanks for your response.

insmod /lib/modules/6.15.4-4-cachyos/kernel/drivers/power/supply/cros_charge-control.ko.zst 

lrwxrwxrwx 1 root root 0 Jul  4 11:52 /sys/bus/platform/devices/cros-ec-chardev.6.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-chardev.6.auto
lrwxrwxrwx 1 root root 0 Jul  4 11:52 /sys/bus/platform/devices/cros-ec-debugfs.7.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-debugfs.7.auto
lrwxrwxrwx 1 root root 0 Jul  4 11:52 /sys/bus/platform/devices/cros-ec-dev.2.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto
lrwxrwxrwx 1 root root 0 Jul  4 11:52 /sys/bus/platform/devices/cros-ec-gpio.3.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-gpio.3.auto
lrwxrwxrwx 1 root root 0 Jul  4 11:52 /sys/bus/platform/devices/cros-ec-hwmon.8.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-hwmon.8.auto
lrwxrwxrwx 1 root root 0 Jul  4 11:52 /sys/bus/platform/devices/cros-ec-led.4.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-led.4.auto
lrwxrwxrwx 1 root root 0 Jul  4 11:51 /sys/bus/platform/devices/cros_ec_lpcs.0 -> ../../../devices/platform/cros_ec_lpcs.0
lrwxrwxrwx 1 root root 0 Jul  4 11:52 /sys/bus/platform/devices/cros-ec-sysfs.9.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-sysfs.9.auto
lrwxrwxrwx 1 root root 0 Jul  4 11:52 /sys/bus/platform/devices/cros-keyboard-leds.5.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-keyboard-leds.5.auto

[   14.272109] cros_ec_lpcs cros_ec_lpcs.0: loaded with quirks 00000001
[   14.308257] cros_ec_lpcs cros_ec_lpcs.0: Chrome EC device registered

I did try the same steps after disabling the "Battery Extender functionality" from bios 3.09, with the same results.

This issue seems to reference the same behavior: MrChromebox/firmware#420 (comment)

I don't have any charge_control sysfs available:

$ grep . /sys/class/power_supply/BAT1/charge_*
/sys/class/power_supply/BAT1/charge_full:3976000
/sys/class/power_supply/BAT1/charge_full_design:3915000
/sys/class/power_supply/BAT1/charge_now:3379000

[linrunner]

The detection logic checks for /sys/bus/platform/devices/cros-charge-control.*.auto/driver which is missing on your system.

@t-8ch Do you have any idea what's going on here? You mentioned a broken firmware in mid March.

[BarbUk]

With ectool:

$ sudo ectool battery
Battery 0 info:
  OEM name:               NVT
  Model number:           FRANGWAT01
  Chemistry   :           LION
  Serial number:          036A
  Design capacity:        3915 mAh
  Last full charge:       3976 mAh
  Design output voltage   15480 mV
  Cycle count             4
  Present voltage         16676 mV
  Present current         -667 mA
  Remaining capacity      3286 mAh
  Desired voltage         17800 mV
  Desired current         3915 mA
  Flags                   0x06 BATT_PRESENT DISCHARGING

$ sudo ectool chargecontrol normal 75 85
Charge state machine is in normal mode with sustainer enabled.

Strace show that the tool talk with /dev/cros_ec:

12:17:33.673440 read(3</dev/cros_ec<char 10:121>>, "1.0.0\nazalea_v3.4.113385-ec:c25dec,os\nazalea_v3.4.113385-ec:c25dec,os\nread-only", 79) = 79 <0.001674>
12:17:33.675153 ioctl(3</dev/cros_ec<char 10:121>>, _IOC(_IOC_READ|_IOC_WRITE, 0x3a, 0, 0x28), 0x7ffec58bbf80) = -1 ENOTTY (Inappropriate ioctl for device) <0.000021>
12:17:33.675221 ioctl(3</dev/cros_ec<char 10:121>>, CROS_EC_DEV_IOCRDMEM, 0x7ffec58bbdd0) = 2 <0.000091>
12:17:33.675374 uname({sysname="Linux", nodename="framework", ...}) = 0 <0.000015>
12:17:33.675440 ioctl(3</dev/cros_ec<char 10:121>>, CROS_EC_DEV_IOCXCMD, 0x55fa439e34c0) = 12 <0.001175>
12:17:33.676670 ioctl(3</dev/cros_ec<char 10:121>>, CROS_EC_DEV_IOCXCMD, 0x55fa439e34f0) = 4 <0.001550>
12:17:33.678301 ioctl(3</dev/cros_ec<char 10:121>>, CROS_EC_DEV_IOCXCMD, 0x55fa439e34c0) = 0 <0.003441>
12:17:33.681833 fstat(1</dev/pts/3<char 136:3>>, {st_mode=S_IFCHR|0620, st_rdev=makedev(0x88, 0x3), ...}) = 0 <0.000018>
12:17:33.681945 write(1</dev/pts/3<char 136:3>>, "Charge state machine is in normal mode with sustainer enabled.\n", 63Charge state machine is in normal mode with sustainer enabled.

But:

$ sudo ectool chargecontrol
Charge mode = NORMAL (0)
Battery sustainer = off (-1% ~ -1%)

[t-8ch]

In any case you'll need to set cros_charge-control.probe_with_fwk_charge_control.

What is the output of ectool inventory?
You probably need a patch to fix compatibility with bios 3.09.

[linrunner]

@t-8ch

In any case you'll need to set cros_charge-control.probe_with_fwk_charge_control.

You once wrote that this is only needed if framework_laptop is also loaded. How do you recognize this situation in the present case?

EDIT: charge_control_end_threshold should be there even with framework_laptop in charge.

[t-8ch]

You once wrote that this is only needed if framework_laptop is also loaded.

It is always necessary on a Framework machine. It is a promise by the user not to use the custom Framework API. Either through framework_laptop, ectool or the firmware setup.
All of them are incompatible with what my driver does.

My hope is that Framework will unify all their features around the upstream API and drop their custom one.

[linrunner]

@t-8ch

It is always necessary on a Framework machine. It is a promise by the user not to use the custom Framework API.

Oops. I must have fundamentally misunderstood you :-(. Thanks for clarifying.

@self hurry to correct the docs ....

[linrunner]

Done: https://linrunner.de/tlp/settings/bc-vendors.html#chromebooks-and-framework

[BarbUk]

Thank you both for your responses.

What is the output of ectool inventory?

EC supported features:
1   : Flash support
2   : Direct Fan power management support
3   : Keyboard backlight support
5   : LED support
7   : Keyboard support
9   : BIOS Port 80h access support
10  : Thermal management support
13  : Host event support
14  : GPIO support
15  : I2C controller support
16  : Charger support
17  : Simple Battery support
18  : Smart Battery support
25  : Temporary secure vstore support
32  : Unified wake masks for LPC/eSPI support
33  : 64-bit host events support
34  : Execute code in RAM support

In any case you'll need to set cros_charge-control.probe_with_fwk_charge_control.

$ sudo modprobe -v cros_charge-control probe_with_fwk_charge_control=1
insmod /lib/modules/6.15.4-4-cachyos/kernel/drivers/power/supply/cros_charge-control.ko.zst probe_with_fwk_charge_control=1

$ ls -l /sys/bus/platform/devices/cros*
lrwxrwxrwx 1 root root 0 Jul  4 13:48 /sys/bus/platform/devices/cros-ec-chardev.6.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-chardev.6.auto
lrwxrwxrwx 1 root root 0 Jul  4 13:48 /sys/bus/platform/devices/cros-ec-debugfs.7.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-debugfs.7.auto
lrwxrwxrwx 1 root root 0 Jul  4 13:48 /sys/bus/platform/devices/cros-ec-dev.2.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto
lrwxrwxrwx 1 root root 0 Jul  4 13:48 /sys/bus/platform/devices/cros-ec-gpio.3.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-gpio.3.auto
lrwxrwxrwx 1 root root 0 Jul  4 13:48 /sys/bus/platform/devices/cros-ec-hwmon.8.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-hwmon.8.auto
lrwxrwxrwx 1 root root 0 Jul  4 13:48 /sys/bus/platform/devices/cros-ec-led.4.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-led.4.auto
lrwxrwxrwx 1 root root 0 Jul  4 13:45 /sys/bus/platform/devices/cros_ec_lpcs.0 -> ../../../devices/platform/cros_ec_lpcs.0
lrwxrwxrwx 1 root root 0 Jul  4 13:48 /sys/bus/platform/devices/cros-ec-sysfs.9.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-sysfs.9.auto
lrwxrwxrwx 1 root root 0 Jul  4 13:48 /sys/bus/platform/devices/cros-keyboard-leds.5.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-keyboard-leds.5.auto

ectool inventory give the same output

You probably need a patch to fix compatibility with bios 3.09.

I will try to build the kernel with this patch and report back.

[BarbUk]

You probably need a patch to fix compatibility with bios 3.09.

Patch applied against stable kernel 6.15.4.
Build without issue.

After reboot:

sudo modprobe -v cros_charge-control probe_with_fwk_charge_control=1
insmod /lib/modules/6.15.4-2-cachyos/kernel/drivers/power/supply/cros_charge-control.ko.zst probe_with_fwk_charge_control=1

[   13.420248] cros_ec_lpcs cros_ec_lpcs.0: loaded with quirks 00000001
[   13.443380] cros_ec_lpcs cros_ec_lpcs.0: Chrome EC device registered
[   13.491349] cros-charge-control cros-charge-control.6.auto: Framework charge control detected, preventing load

Now I have:

$ ls -l /sys/bus/platform/devices/cros*
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros-charge-control.6.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-charge-control.6.auto
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros-ec-chardev.7.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-chardev.7.auto
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros-ec-debugfs.8.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-debugfs.8.auto
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros-ec-dev.2.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros-ec-gpio.3.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-gpio.3.auto
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros-ec-hwmon.9.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-hwmon.9.auto
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros-ec-led.4.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-led.4.auto
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros_ec_lpcs.0 -> ../../../devices/platform/cros_ec_lpcs.0
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros-ec-sysfs.10.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-ec-sysfs.10.auto
lrwxrwxrwx 1 root root 0 Jul  4 14:48 /sys/bus/platform/devices/cros-keyboard-leds.5.auto -> ../../../devices/platform/cros_ec_lpcs.0/cros-ec-dev.2.auto/cros-keyboard-leds.5.auto

$ ls -l /sys/bus/platform/devices/cros-charge-control.*.auto/
-rw-r--r-- 1 root root 4096 Jul  4 14:51 driver_override
-r--r--r-- 1 root root 4096 Jul  4 14:51 modalias
drwxr-xr-x 2 root root    0 Jul  4 14:51 power
lrwxrwxrwx 1 root root    0 Jul  4 14:51 subsystem -> ../../../../../bus/platform
-rw-r--r-- 1 root root 4096 Jul  4 14:51 uevent

$ cat /sys/bus/platform/devices/cros-charge-control.*.auto/driver_override
(null)