ingest_mdir: reject invalid --test and --disable-test values

Currently, if we specify an invalid test name such as "checkpatch"
instead of "patch/checkpatch", the script falls through with no test
run, and no indication as to what was wrong. That is admittedly not very
friendly.

We'd need to call list_tests regardless of whether the --list-tests
argument was specified, and validate against its output. However, this
makes it redundant to have that function, we can just move it into main().

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Author: vladimiroltean

ingest_mdir.py

@@ -264,11 +264,16 @@ def load_patches(args):
     return series
 
 
-def list_tests(args, config):
-    """ List all available tests and exit """
+def validate_test_list(test_list, all_test_names, parser_instance, error_description):
+    """Check a list of test names against the set of all available tests."""
+    if test_list:
+        invalid_tests = [name for name in test_list if name not in all_test_names]
 
-    tester = Tester(args.result_dir, None, None, None, config=config)
-    print(' ', '\n  '.join(tester.get_test_names()))
+        if invalid_tests:
+            invalid_str = ', '.join(invalid_tests)
+            msg = f"the following {error_description} are invalid: {invalid_str}\n" \
+                  f"Run with --list-tests to see available tests."
+            parser_instance.error(msg)
 
 
 def main():
@@ -286,15 +291,28 @@ def main():
         YELLOW = ''
         RESET = ''
 
-    if args.test:
-        config.set('tests', 'include', ','.join(args.test))
+    # Get all available test names for validation and --list-tests
+    # We can instantiate a temporary Tester just for this purpose.
+    tester_for_names = Tester(None, None, None, None, config=config)
+    all_test_names = set(tester_for_names.get_test_names())
 
-    # Handle --list-tests first, as it needs no other arguments
+    # Handle --list-tests first (using the list we just fetched)
     if args.list_tests:
-        list_tests(args, config)
+        print(' ', '\n  '.join(sorted(all_test_names)))
         return
 
-    # If not listing tests, manually validate the required arguments
+    # Validate --test and --disable-test
+    validate_test_list(args.test, all_test_names, parser, "tests")
+    validate_test_list(args.disable_test, all_test_names, parser, "disabled tests")
+
+    # Set configs after validation
+    if args.test:
+        config.set('tests', 'include', ','.join(args.test))
+
+    if args.disable_test:
+        config.set('tests', 'exclude', ','.join(args.disable_test))
+
+    # If not listing tests, manually validate the other required arguments
     if not args.tree:
         parser.error("the following arguments are required: --tree")