From 6d01a780b6843ec19e62619277e361225aad35c6 Mon Sep 17 00:00:00 2001
From: gongheng <gongheng@uniontech.com>
Date: Tue, 29 Jul 2025 15:13:14 +0800
Subject: [PATCH] Perf: [cppcheck] parameter should be passed by const
 reference.

-- Local variable "items" shadows outer variable.
-- Function parameter should be passed by const reference.
---
 deepin-devicemanager/src/DeviceManager/DeviceGpu.cpp     | 8 ++++----
 deepin-devicemanager/src/DeviceManager/DeviceManager.cpp | 2 +-
 deepin-devicemanager/src/DeviceManager/DeviceManager.h   | 2 +-
 deepin-devicemanager/src/DeviceManager/DeviceNetwork.cpp | 2 +-
 deepin-devicemanager/src/DeviceManager/DeviceNetwork.h   | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/deepin-devicemanager/src/DeviceManager/DeviceGpu.cpp b/deepin-devicemanager/src/DeviceManager/DeviceGpu.cpp
index 8eff786a5..1d45c2c64 100644
--- a/deepin-devicemanager/src/DeviceManager/DeviceGpu.cpp
+++ b/deepin-devicemanager/src/DeviceManager/DeviceGpu.cpp
@@ -168,12 +168,12 @@ bool DeviceGpu::setHwinfoInfo(const QMap<QString, QString> &mapInfo)
             foreach (const QString &item, items) {
                 if (item.isEmpty())
                     continue;
-                QStringList items = allStr.split(":", QString::SkipEmptyParts);
-                if (items.size() != 2)
+                QStringList tmpItems = allStr.split(":", QString::SkipEmptyParts);
+                if (tmpItems.size() != 2)
                     continue;
-                if (items.first().trimmed() == "VRAM total size") {
+                if (tmpItems.first().trimmed() == "VRAM total size") {
                     bool ok;
-                    quint64 vramSize = items.last().trimmed().toULong(&ok, 16);
+                    quint64 vramSize = tmpItems.last().trimmed().toULong(&ok, 16);
                     if (ok && vramSize >= 1048576) {
                         vramSize /= 1048576;
                         auto curSize = vramSize / 1024.0;
diff --git a/deepin-devicemanager/src/DeviceManager/DeviceManager.cpp b/deepin-devicemanager/src/DeviceManager/DeviceManager.cpp
index 3a052589d..ab0542521 100644
--- a/deepin-devicemanager/src/DeviceManager/DeviceManager.cpp
+++ b/deepin-devicemanager/src/DeviceManager/DeviceManager.cpp
@@ -1299,7 +1299,7 @@ DeviceBaseInfo *DeviceManager::getNetworkDevice(const QString &unique_id)
     return nullptr;
 }
 
-void DeviceManager::correctNetworkLinkStatus(QString linkStatus, QString networkDriver)
+void DeviceManager::correctNetworkLinkStatus(const QString &linkStatus, const QString &networkDriver)
 {
     if (m_ListDeviceNetwork.size() == 0)
         return;
diff --git a/deepin-devicemanager/src/DeviceManager/DeviceManager.h b/deepin-devicemanager/src/DeviceManager/DeviceManager.h
index cc6740b8d..53458b821 100644
--- a/deepin-devicemanager/src/DeviceManager/DeviceManager.h
+++ b/deepin-devicemanager/src/DeviceManager/DeviceManager.h
@@ -387,7 +387,7 @@ class DeviceManager : public QObject
      * @brief correctNetworkLinkStatus:校正网络连接状态
      * @param linkStatus:连接状态
      */
-    void correctNetworkLinkStatus(QString linkStatus, QString networkDriver);
+    void correctNetworkLinkStatus(const QString &linkStatus, const QString &networkDriver);
 
     /**
      * @brief networkDriver:获取所有网络驱动
diff --git a/deepin-devicemanager/src/DeviceManager/DeviceNetwork.cpp b/deepin-devicemanager/src/DeviceManager/DeviceNetwork.cpp
index 805bdee55..3f9f6f048 100644
--- a/deepin-devicemanager/src/DeviceManager/DeviceNetwork.cpp
+++ b/deepin-devicemanager/src/DeviceManager/DeviceNetwork.cpp
@@ -224,7 +224,7 @@ bool DeviceNetwork::enable()
     return m_Enable;
 }
 
-void DeviceNetwork::correctCurrentLinkStatus(QString linkStatus)
+void DeviceNetwork::correctCurrentLinkStatus(const QString &linkStatus)
 {
     if (m_Link != linkStatus)
         m_Link = linkStatus;
diff --git a/deepin-devicemanager/src/DeviceManager/DeviceNetwork.h b/deepin-devicemanager/src/DeviceManager/DeviceNetwork.h
index 6b050289a..1bbda454d 100644
--- a/deepin-devicemanager/src/DeviceManager/DeviceNetwork.h
+++ b/deepin-devicemanager/src/DeviceManager/DeviceNetwork.h
@@ -92,7 +92,7 @@ class DeviceNetwork : public DeviceBaseInfo
      * @brief correctCurrentLinkStatus
      * @param linkStatus
      */
-    void correctCurrentLinkStatus(QString linkStatus);
+    void correctCurrentLinkStatus(const QString &linkStatus);
 
     /**
      * @brief logicalName: 获取网卡逻辑名称