diff --git a/deepin-devicemanager/src/DriverControl/DBusDriverInterface.cpp b/deepin-devicemanager/src/DriverControl/DBusDriverInterface.cpp index 5948f8c62..62b55faec 100644 --- a/deepin-devicemanager/src/DriverControl/DBusDriverInterface.cpp +++ b/deepin-devicemanager/src/DriverControl/DBusDriverInterface.cpp @@ -113,12 +113,12 @@ DBusDriverInterface::~DBusDriverInterface() } -void DBusDriverInterface::slotProcessChange(qint32 value, QString detail) +void DBusDriverInterface::slotProcessChange(qint32 value, const QString &detail) { emit processChange(value, detail); } -void DBusDriverInterface::slotProcessEnd(bool success, QString msg) +void DBusDriverInterface::slotProcessEnd(bool success, const QString &msg) { if (success) { emit processChange(100, ""); @@ -133,7 +133,7 @@ void DBusDriverInterface::slotCallFinished(QDBusPendingCallWatcher *watcher) watcher->deleteLater(); } -void DBusDriverInterface::slotDownloadProgressChanged(QStringList msg) +void DBusDriverInterface::slotDownloadProgressChanged(const QStringList &msg) { emit downloadProgressChanged(msg); } diff --git a/deepin-devicemanager/src/DriverControl/DBusDriverInterface.h b/deepin-devicemanager/src/DriverControl/DBusDriverInterface.h index bd221158e..709b32f70 100644 --- a/deepin-devicemanager/src/DriverControl/DBusDriverInterface.h +++ b/deepin-devicemanager/src/DriverControl/DBusDriverInterface.h @@ -123,13 +123,13 @@ private slots: * @param value 当前处理的进度 * @param detail 发送过来的时时信息 */ - void slotProcessChange(qint32 value, QString detail); + void slotProcessChange(qint32 value, const QString &detail); /** * @brief slotProcessEnd 接收后台结束信号 * @param success */ - void slotProcessEnd(bool success, QString msg); + void slotProcessEnd(bool success, const QString &msg); /** * @brief slotCallFinished 更新结束结束的回调 @@ -139,7 +139,7 @@ private slots: /** * @brief slotDownloadProgressChanged 驱动下载时回调,返回驱动下载进度、速度、已下载大小信息 */ - void slotDownloadProgressChanged(QStringList msg); + void slotDownloadProgressChanged(const QStringList &msg); /** * @brief slotDownloadFinished 驱动下载完成 diff --git a/deepin-devicemanager/src/DriverControl/DriverScanner.cpp b/deepin-devicemanager/src/DriverControl/DriverScanner.cpp index 76fc09026..e3ec41d40 100644 --- a/deepin-devicemanager/src/DriverControl/DriverScanner.cpp +++ b/deepin-devicemanager/src/DriverControl/DriverScanner.cpp @@ -81,7 +81,7 @@ void DriverScanner::run() // emit scanFinished(SR_SUCESS); } -void DriverScanner::setDriverList(QList lstInfo) +void DriverScanner::setDriverList(const QList &lstInfo) { m_ListDriverInfo = lstInfo; m_IsStop = false; diff --git a/deepin-devicemanager/src/DriverControl/DriverScanner.h b/deepin-devicemanager/src/DriverControl/DriverScanner.h index ae1d7ddce..7439cba3b 100644 --- a/deepin-devicemanager/src/DriverControl/DriverScanner.h +++ b/deepin-devicemanager/src/DriverControl/DriverScanner.h @@ -25,7 +25,7 @@ class DriverScanner : public QThread * @brief setDriverList * @param lstInfo */ - void setDriverList(QList lstInfo); + void setDriverList(const QList &lstInfo); signals: void scanInfo(const QString &info, int progress); diff --git a/deepin-devicemanager/src/GenerateDevice/CmdTool.cpp b/deepin-devicemanager/src/GenerateDevice/CmdTool.cpp index 1679baa77..529e43a55 100644 --- a/deepin-devicemanager/src/GenerateDevice/CmdTool.cpp +++ b/deepin-devicemanager/src/GenerateDevice/CmdTool.cpp @@ -184,7 +184,7 @@ QString CmdTool::loadOemTomlFileName(const QMap &mapInfo) return QString(); } -bool CmdTool::parseOemTomlInfo(const QString filename) +bool CmdTool::parseOemTomlInfo(const QString &filename) { bool tomlFileRead = false; bool tomlPars = false; @@ -969,9 +969,9 @@ void CmdTool::loadNvidiaSettingInfo(const QString &key, const QString &debugfile QRegExp reg("[\\s\\S]*VideoRam[\\s\\S]*([0-9]{4,})[\\s\\S]*"); QStringList list = deviceInfo.split("\n"); - foreach (QString item, list) { + foreach (QString tmpInfo, list) { // Attribute 'VideoRam' (jixiaomei-PC:0.0): 2097152. 正则表达式获取2097152 - if (reg.exactMatch(item)) { + if (reg.exactMatch(tmpInfo)) { QString gpuSize = reg.cap(1); int numSize = gpuSize.toInt(); numSize /= 1024; diff --git a/deepin-devicemanager/src/GenerateDevice/CmdTool.h b/deepin-devicemanager/src/GenerateDevice/CmdTool.h index f838f9d81..61ceb888a 100644 --- a/deepin-devicemanager/src/GenerateDevice/CmdTool.h +++ b/deepin-devicemanager/src/GenerateDevice/CmdTool.h @@ -61,7 +61,7 @@ class CmdTool /** * @brief parseOemTomlInfo: 解析并加载厂商适配信息 */ - bool parseOemTomlInfo(const QString filename); + bool parseOemTomlInfo(const QString &filename); private: diff --git a/deepin-devicemanager/src/GenerateDevice/CustomGenerator.h b/deepin-devicemanager/src/GenerateDevice/CustomGenerator.h index 9901d2ad4..4ef8f2422 100644 --- a/deepin-devicemanager/src/GenerateDevice/CustomGenerator.h +++ b/deepin-devicemanager/src/GenerateDevice/CustomGenerator.h @@ -11,7 +11,7 @@ class CustomGenerator : public DeviceGenerator { public: - CustomGenerator(QObject *parent = nullptr); + explicit CustomGenerator(QObject *parent = nullptr); /** * @brief generatorGpuDevice:生成显卡信息 diff --git a/deepin-devicemanager/src/GenerateDevice/GenerateDevicePool.h b/deepin-devicemanager/src/GenerateDevice/GenerateDevicePool.h index 7fe9d03e4..1de9195dc 100644 --- a/deepin-devicemanager/src/GenerateDevice/GenerateDevicePool.h +++ b/deepin-devicemanager/src/GenerateDevice/GenerateDevicePool.h @@ -45,7 +45,7 @@ class GenerateTask: public QObject, public QRunnable Q_OBJECT public: - GenerateTask(DeviceType deviceType); + explicit GenerateTask(DeviceType deviceType); ~GenerateTask(); signals: void finished(const QStringList &lst); diff --git a/deepin-devicemanager/src/GenerateDevice/GetInfoPool.cpp b/deepin-devicemanager/src/GenerateDevice/GetInfoPool.cpp index 1204c0131..33645eb0c 100644 --- a/deepin-devicemanager/src/GenerateDevice/GetInfoPool.cpp +++ b/deepin-devicemanager/src/GenerateDevice/GetInfoPool.cpp @@ -12,7 +12,7 @@ static QMutex mutex; -CmdTask::CmdTask(QString key, QString file, QString info, GetInfoPool *parent) +CmdTask::CmdTask(const QString &key, const QString &file, const QString &info, GetInfoPool *parent) : m_Key(key) , m_File(file) , m_Info(info) diff --git a/deepin-devicemanager/src/GenerateDevice/GetInfoPool.h b/deepin-devicemanager/src/GenerateDevice/GetInfoPool.h index 4582b1f8b..c207baa6c 100644 --- a/deepin-devicemanager/src/GenerateDevice/GetInfoPool.h +++ b/deepin-devicemanager/src/GenerateDevice/GetInfoPool.h @@ -19,8 +19,8 @@ class CmdTask: public QObject, public QRunnable { Q_OBJECT public: - CmdTask(QString key, QString file, QString info, GetInfoPool *parent); - ~CmdTask(); + CmdTask(const QString &key, const QString &file, const QString &info, GetInfoPool *parent); + ~CmdTask() override; protected: void run() override; diff --git a/deepin-devicemanager/src/GenerateDevice/LoadInfoThread.h b/deepin-devicemanager/src/GenerateDevice/LoadInfoThread.h index 051468d94..440f285b0 100644 --- a/deepin-devicemanager/src/GenerateDevice/LoadInfoThread.h +++ b/deepin-devicemanager/src/GenerateDevice/LoadInfoThread.h @@ -16,7 +16,7 @@ class LoadInfoThread : public QThread Q_OBJECT public: LoadInfoThread(); - ~LoadInfoThread(); + ~LoadInfoThread() override; /** * @brief setFramework:设置架构 diff --git a/deepin-devicemanager/src/Page/DeviceWidget.h b/deepin-devicemanager/src/Page/DeviceWidget.h index 4a79f5c26..586cf400f 100644 --- a/deepin-devicemanager/src/Page/DeviceWidget.h +++ b/deepin-devicemanager/src/Page/DeviceWidget.h @@ -26,7 +26,7 @@ class DeviceWidget : public DWidget Q_OBJECT public: explicit DeviceWidget(QWidget *parent = nullptr); - ~DeviceWidget(); + ~DeviceWidget() override; /** * @brief updateListView:更新ListView diff --git a/deepin-devicemanager/src/Page/MainWindow.cpp b/deepin-devicemanager/src/Page/MainWindow.cpp index 6a932a226..3249cc747 100644 --- a/deepin-devicemanager/src/Page/MainWindow.cpp +++ b/deepin-devicemanager/src/Page/MainWindow.cpp @@ -474,7 +474,7 @@ void MainWindow::refreshDataBase() } } -void MainWindow::slotSetPage(QString page) +void MainWindow::slotSetPage(const QString &page) { if ("driver" == page) { if (m_IsFirstRefresh) { diff --git a/deepin-devicemanager/src/Page/MainWindow.h b/deepin-devicemanager/src/Page/MainWindow.h index 2dcd93f72..6a60c8fd7 100644 --- a/deepin-devicemanager/src/Page/MainWindow.h +++ b/deepin-devicemanager/src/Page/MainWindow.h @@ -134,7 +134,7 @@ private slots: * @brief slotSetPage * @param page */ - void slotSetPage(QString page); + void slotSetPage(const QString &page); /** * @brief loadingFinishSlot:加载设备信息结束 槽