ISO C99 and later do not support implicit int

[mathbird]

Hi,

I am trying to build mpiP using "icx" on intel CPUs, but met the following issue. how to fix it?

pc_lookup.c:115:41: error: parameter 'data' was not declared, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
find_address_in_section (abfd, section, data)
                                        ^
pc_lookup.c:118:6: error: expected function body after function declarator
     PTR data;
     ^
pc_lookup.c:119:1: error: expected identifier or '('
{
^
pc_lookup.c:438:58: error: use of undeclared identifier 'PTR'
  bfd_map_over_sections (abfd, find_address_in_section, (PTR) NULL);
                                                         ^
pc_lookup.c:438:32: error: use of undeclared identifier 'find_address_in_section'
  bfd_map_over_sections (abfd, find_address_in_section, (PTR) NULL);
                               ^
pc_lookup.c:480:35: error: use of undeclared identifier 'PTR'
                                 (PTR) NULL);
                                  ^
pc_lookup.c:479:44: error: use of undeclared identifier 'find_address_in_section'
          bfd_map_over_sections (fso->bfd, find_address_in_section,
                                           ^
7 errors generated.
make: *** [Rules.mak:6: pc_lookup.o] Error 1

[mathbird]

here is the configure output

********************************************************************************
  mpiP Configuration Summary

  C compiler               : mpicc
  C++ compiler             : icpx
  Fortran compiler         : ifx
  Python                   : python

  Timer                    : MPI_Wtime
  Stack Unwinding          : libunwind
  Address to Source Lookup : bfd

  MPI-I/O support          : yes
  MPI-RMA support          : yes
  MPI-NBC support          : yes
********************************************************************************

[mathbird]

if I change find_address_in_section in pc_lookup.c as follows, the compiler then said "pc_lookup.c:121:56: error: unknown type name 'PTR'"

// static void
// find_address_in_section (abfd, section, data)
//      bfd *abfd;
//      asection *section;
//      PTR data;

static void
find_address_in_section (bfd *abfd, asection *section, PTR  data)

[cponder]

I'm using the NVHPC 25.1 compiler. The mpiP built ok under Ubuntu 22.04, but with Ubuntu 24.04 it gave me the similar error:

#86 16.42 mpicc -O2 -m64 -tp=native -fpic -fPIC -gopt -fpic -DPIC -I/usr/local/pgi/Linux_x86_64/cuda/12.6/include -I. -DX86_64 -DLinux -c pc_lookup.c -o pc_lookup.o
#86 16.53 "pc_lookup.c", line 118: error: identifier "PTR" is undefined
#86 16.53        PTR data;
#86 16.53        ^

#86 16.53 "pc_lookup.c", line 438: error: identifier "PTR" is undefined
#86 16.53     bfd_map_over_sections (abfd, find_address_in_section, (PTR) NULL);
#86 16.53                                                            ^

I didn't make any source changes. I'm using mpiP version 3.5.

[cponder]

I do notice that this message comes up with Ubuntu 24.04 but not 22.04:

#86 8.941 /usr/local/src/mpiP-3.5/./make-wrappers.py:847: SyntaxWarning: invalid escape sequence '\@'

From googling around,

https://stackoverflow.com/questions/52335970/how-to-fix-syntaxwarning-invalid-escape-sequence-in-python

I think it's because Ubuntu 24.04 uses Python 3.12.3 which Ubuntu 22.04 uses Python 3.10.12.
What I don't know, though, is what this construction represents

    847         line = re.sub("\@.*$","",rawline)

whether the backslash is meant to literalize the @-sign, or if backslash-@ is supposed to convert to some other special character, or if the backslash itself is meant as a literal.
I'd be ok with inserting a sed-substitution into my build-script, but I can't tell what to put in here.