Services menu: The machine-readable name must contain only lowercase letters, numbers, and hyphens.

[msayoung]

If you visit the Services menu overview ( admin/structure/menu/manage/localgov_services_menu ) and try and enable or disable a link, or reorder menu items, when you press Save you get the error message:

The machine-readable name must contain only lowercase letters, numbers, and hyphens.

The machine name is localgov_services_menu

[finnlewis]

Crikey!

Discussing at Merge Tuesday.

@tonypaulbarker points out that if we deploy an update hook that changes the menu name, this could have unexpected consequences. We'd need to update anything that references the menu. Blocks, demo content etc.

We could just fix this for new installs first.

@tonypaulbarker raised this and we should fix it properly.

[andybroomfield]

Raised originally in #140! so this has been around for a while.

[rbg-lslater]

Just encountered this at Greenwich too.

Interestingly, there's an open issue and patch to allow underscores in menu names. Not sure how likely this is to make it into Core, but looks like a simple change (might need some work to backport to Drupal 10 though?). Just tested and that patch seems to work okay on D10.

[andybroomfield]

Have added a PR to change this for new installs in #340 and a corresponding one in localgovdrupal/localgov_demo#156.

I don't think there is anything more to do. We could provide an update hook for past installs, though the simplest solution for sites where this is an issue is often to recreate the menu with the correct naming conventions and copy the items over by hand.

[finnlewis]

Fixed with https://www.drupal.org/project/localgov_services/releases/2.2.1