Skip to content

Commit bce549c

Browse files
committed
fixes and improvements
1 parent 40d81a8 commit bce549c

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

localstack_utils/container.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,20 @@
2323
class Container:
2424
@staticmethod
2525
def create_localstack_container(
26-
pull_new_image: bool,
27-
image_name: str = None,
26+
*args,
27+
pull_new_image: bool = False,
28+
image_name: str = LOCALSTACK_IMAGE_NAME,
2829
image_tag: str = LATEST_TAG,
2930
gateway_listen: str = "0.0.0.0:4566",
30-
environment_variables: dict = None,
31-
bind_ports: dict = None,
31+
environment_variables: dict | None = None,
32+
bind_ports: dict | None = None,
33+
**kwargs,
3234
):
3335
environment_variables = environment_variables or {}
3436
environment_variables["GATEWAY_LISTEN"] = gateway_listen
3537

36-
image_name_or_default = image_name or LOCALSTACK_IMAGE_NAME
3738
image_exists = (
38-
True
39-
if len(DOCKER_CLIENT.images.list(name=image_name_or_default))
40-
else False
39+
True if len(DOCKER_CLIENT.images.list(name=image_name)) else False
4140
)
4241

4342
bind_ports = bind_ports or {}
@@ -46,10 +45,10 @@ def create_localstack_container(
4645

4746
if pull_new_image or not image_exists:
4847
logging.info("Pulling latest image")
49-
DOCKER_CLIENT.images.pull(image_name_or_default, image_tag)
48+
DOCKER_CLIENT.images.pull(image_name, image_tag)
5049

5150
return DOCKER_CLIENT.containers.run(
52-
image_name_or_default,
51+
image_name,
5352
ports=bind_ports,
5453
environment=environment_variables,
5554
detach=True,

0 commit comments

Comments
 (0)