-
Notifications
You must be signed in to change notification settings - Fork 1
Fix logLevel not being applied in development environments #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughRefactors logging resolver functions to consistently return LoggerOptions and separate configuration building from logger instantiation. Introduces and exports resolveLoggerConfiguration. Updates resolveLogger and resolveMonorepoLogger to use configuration builders. Test suite removes dev-environment test, renames a test, and retains remaining validation and redaction tests. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller
participant Resolver as resolveLogger
participant Builder as resolveLoggerConfiguration
participant Logger as Logger.create
Caller->>Resolver: resolveLogger(appConfig)
Resolver->>Builder: build LoggerOptions
Builder-->>Resolver: LoggerOptions
Resolver->>Logger: instantiate with LoggerOptions
Logger-->>Caller: Logger
note over Resolver,Builder: Configuration building separated from instantiation
sequenceDiagram
autonumber
actor Caller
participant Mono as resolveMonorepoLogger
participant MonoCfg as resolveMonorepoLoggerConfiguration
participant Logger as Logger.create
Caller->>Mono: resolveMonorepoLogger(appConfig)
Mono->>MonoCfg: build LoggerOptions
MonoCfg-->>Mono: LoggerOptions
Mono->>Logger: instantiate with LoggerOptions
Logger-->>Caller: Logger
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
This PR fixes the issue with logger configuration not resolving to a correct
logLevelfor non-productionenvironments.Summary by CodeRabbit
Refactor
Tests