Add jade task #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
There was a problem hiding this comment.
Do we need to5, ngHtml2Js and insert for this task?
Author
There was a problem hiding this comment.
Well they aren't really needed and i really just copied the ngHtml2js task. Although, i think ngHtml2Js should be optional i.e to embed or not to embed.
Owner
There was a problem hiding this comment.
I agree with you on the ngHtml2Js as that will prevent having to do another step for the transform... it should only be invoked if there is options that define it though... =)
Update your PR and I'll merge it. =)
Owner
|
Thanks for the contribution! Let's just discuss the changes above and make any updates. Once we agree, I'll merge this in ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This adds a jade task which creates angular partials.