From ae62c4a1450c21923ad0c1a99a7ef187bd4d5466 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 23 Nov 2022 01:03:12 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../mxnet/python/mxnet/gluon/data/vision.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/perception/detect/mxnet_ssd/mxnet/python/mxnet/gluon/data/vision.py b/perception/detect/mxnet_ssd/mxnet/python/mxnet/gluon/data/vision.py index 54da152..9811af1 100644 --- a/perception/detect/mxnet_ssd/mxnet/python/mxnet/gluon/data/vision.py +++ b/perception/detect/mxnet_ssd/mxnet/python/mxnet/gluon/data/vision.py @@ -204,7 +204,26 @@ def _get_data(self): sha1_hash=self._archive_file[1]) with tarfile.open(filename) as tar: - tar.extractall(self._root) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, self._root) if self._train: data_files = self._train_data