Updated the documentation

Author: jadenPete-lucid

README.md

@@ -9,10 +9,12 @@ vastly improve build times. However, to see these benefits, a project must first
 tiny packages and make use of fine-grained dependencies. This is not always a realistic short-term
 goal for large, monorepo Scala projects.
 
-`lucidsoftware/rules_scala` allows for the optional use of Zinc incremental compilation to provide a
-stepping stone for these projects as they migrate to Bazel. Although we've verified it to be correct
-and determinisitc, we recommend leaving this disabled, as fine-grained and isolated targets are
-more in-line with the [Bazel philosophy](https://bazel.build/basics/hermeticity).
+`lucidsoftware/rules_scala` used to allow for the optional use of Zinc incremental compilation to
+provide a stepping stone for these projects as they migrate to Bazel. Although we still reuse code
+from Zinc and the compiler bridge, this ruleset no longer supports incremental compilation.
+Mitigating nondeterminism issues required introducing an enormous amount of complexity to the
+compilation worker, and we eventually discovered that supporting incremental compilation added
+substantial overhead to compilation times.
 
 `lucidsoftware/rules_scala` is written with maintainability and accessibility in mind. It aims to
 facilitate the transition to Bazel, and to satisfy use cases throughout the Scala ecosystem.
@@ -40,7 +42,6 @@ straightforward.
   * Errors on indirect and unused dependencies
   * Buildozer suggestions for dependency errors
 * [Optional Worker strategy](docs/scala.md#workers)
-* [Optional Zinc-based stateful incremental compilation](docs/stateful.md#stateful-compilation)
 * [Scalafmt](docs/scalafmt.md#scalafmt) integration
 * Protobuf support with ScalaPB
   * [scala_proto_library](docs/stardoc/scala_proto.md#scala_proto_library)
@@ -49,7 +50,6 @@ straightforward.
 * [Customizable rules](docs/newdocs/phases.md#customizing-the-core-rules)
 * [Multiple Scala versions in one build](docs/newdocs/scala_versions.md#specifying-the-scala-version-to-use), including Scala 3 (Dotty).
 * [Optimal handling of macros and ijars](docs/newdocs/macros.md#macros-and-ijars)
-* [Pass flags to Zinc compiler](docs/newdocs/zinc_flags.md)
 * Modern implementation using Bazel's most idiomatic APIs
 
 ## Usage

docs/newdocs/zinc_flags.md

@@ -221,7 +221,7 @@ Generates Scaladoc.
 <pre>
 load("@rules_scala_annex//rules:scala.bzl", "make_scala_binary")
 
-make_scala_binary(<a href="#make_scala_binary-extras">extras</a>)
+make_scala_binary(<a href="#make_scala_binary-extras">*extras</a>)
 </pre>
 
 
@@ -241,7 +241,7 @@ make_scala_binary(<a href="#make_scala_binary-extras">extras</a>)
 <pre>
 load("@rules_scala_annex//rules:scala.bzl", "make_scala_library")
 
-make_scala_library(<a href="#make_scala_library-extras">extras</a>)
+make_scala_library(<a href="#make_scala_library-extras">*extras</a>)
 </pre>
 
 
@@ -261,7 +261,7 @@ make_scala_library(<a href="#make_scala_library-extras">extras</a>)
 <pre>
 load("@rules_scala_annex//rules:scala.bzl", "make_scala_test")
 
-make_scala_test(<a href="#make_scala_test-extras">extras</a>)
+make_scala_test(<a href="#make_scala_test-extras">*extras</a>)
 </pre>
 
 

docs/stardoc/scala.md

@@ -33,7 +33,7 @@ See example use in [/tests/proto/BUILD](/tests/proto/BUILD)
 <pre>
 load("@rules_scala_annex//rules:scala_proto.bzl", "scala_proto_toolchain")
 
-scala_proto_toolchain(<a href="#scala_proto_toolchain-name">name</a>, <a href="#scala_proto_toolchain-compiler">compiler</a>, <a href="#scala_proto_toolchain-compiler_supports_workers">compiler_supports_workers</a>)
+scala_proto_toolchain(<a href="#scala_proto_toolchain-name">name</a>, <a href="#scala_proto_toolchain-compiler">compiler</a>, <a href="#scala_proto_toolchain-compiler_supports_workers">compiler_supports_workers</a>, <a href="#scala_proto_toolchain-protoc">protoc</a>)
 </pre>
 
 Specifies a toolchain of the `@rules_scala_annex//rules/scala_proto:compiler_toolchain_type` toolchain type.
@@ -73,7 +73,8 @@ toolchain(
 | Name  | Description | Type | Mandatory | Default |
 | :------------- | :------------- | :------------- | :------------- | :------------- |
 | <a id="scala_proto_toolchain-name"></a>name |  A unique name for this target.   | <a href="https://bazel.build/concepts/labels#target-names">Name</a> | required |  |
-| <a id="scala_proto_toolchain-compiler"></a>compiler |  The compiler to use to generate Scala form proto sources   | <a href="https://bazel.build/concepts/labels">Label</a> | optional |  `None`  |
+| <a id="scala_proto_toolchain-compiler"></a>compiler |  The compiler to use to generate Scala form proto sources   | <a href="https://bazel.build/concepts/labels">Label</a> | required |  |
 | <a id="scala_proto_toolchain-compiler_supports_workers"></a>compiler_supports_workers |  -   | Boolean | optional |  `False`  |
+| <a id="scala_proto_toolchain-protoc"></a>protoc |  The protoc binary to use   | <a href="https://bazel.build/concepts/labels">Label</a> | optional |  `"@protobuf//:protoc"`  |