wip: nfs

Author: bensmrs

.github/workflows/tests.yml

@@ -135,57 +135,9 @@ jobs:
           - cluster
           - standalone
         backend:
-          - dir
-          - btrfs
-          - lvm
-          - zfs
-          - ceph
-          - linstor
-          - random
+          - nfs
         os:
           - ubuntu-24.04
-        include:
-          - go: oldstable
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04
-          - go: oldstable
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04
-          - go: tip
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04
-          - go: tip
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04
-
-          - go: oldstable
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: oldstable
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: stable
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: stable
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: tip
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: tip
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04-arm
     runs-on: ${{ matrix.os }}
 
     steps:
@@ -434,6 +386,15 @@ jobs:
           # Update the runner env.
           echo "INCUS_LINSTOR_CLUSTER=${runner_ip}" >> "$GITHUB_ENV"
 
+      - name: Setup NFS
+        if: ${{ matrix.backend == 'nfs' }}
+        run: |
+          set -x
+          sudo apt-get install --no-install-recommends -y nfs-kernel-server
+          echo "/media 10.0.0.0/8(rw,sync,no_subtree_check,no_root_squash,no_all_squash)" | sudo tee /etc/exports
+          sudo exportfs -a
+          echo "INCUS_NFS_HOST=$(hostname -I | cut -d' ' -f1)" >> "$GITHUB_ENV"
+
       - name: "Ensure offline mode (block image server)"
         run: |
           sudo nft add table inet filter
@@ -457,7 +418,7 @@ jobs:
           chmod +x ~
           echo "root:1000000:1000000000" | sudo tee /etc/subuid /etc/subgid
           cd test
-          sudo --preserve-env=PATH,GOPATH,GITHUB_ACTIONS,INCUS_VERBOSE,INCUS_BACKEND,INCUS_CEPH_CLUSTER,INCUS_CEPH_CEPHFS,INCUS_CEPH_CEPHOBJECT_RADOSGW,INCUS_LINSTOR_LOCAL_SATELLITE,INCUS_LINSTOR_CLUSTER,INCUS_OFFLINE,INCUS_SKIP_TESTS,INCUS_REQUIRED_TESTS, INCUS_BACKEND=${{ matrix.backend }} ./main.sh ${{ matrix.suite }}
+          sudo --preserve-env=PATH,GOPATH,GITHUB_ACTIONS,INCUS_VERBOSE,INCUS_BACKEND,INCUS_CEPH_CLUSTER,INCUS_CEPH_CEPHFS,INCUS_CEPH_CEPHOBJECT_RADOSGW,INCUS_LINSTOR_LOCAL_SATELLITE,INCUS_LINSTOR_CLUSTER,INCUS_NFS_HOST,INCUS_OFFLINE,INCUS_SKIP_TESTS,INCUS_REQUIRED_TESTS, INCUS_BACKEND=${{ matrix.backend }} ./main.sh ${{ matrix.suite }}
 
   client:
     name: Client

test/backends/nfs.sh

@@ -0,0 +1,31 @@
+nfs_setup() {
+    # shellcheck disable=2039,3043
+    local INCUS_DIR
+
+    INCUS_DIR=$1
+
+    echo "==> Setting up nfs backend in ${INCUS_DIR}"
+    mkdir "/media/$(basename "$INCUS_DIR")"
+}
+
+nfs_configure() {
+    # shellcheck disable=2039,3043
+    local INCUS_DIR
+
+    INCUS_DIR=$1
+
+    echo "==> Configuring nfs backend in ${INCUS_DIR}"
+
+    incus storage create "incustest-$(basename "${INCUS_DIR}")" nfs nfs.host="${INCUS_NFS_HOST}" "source=/media/$(basename "$INCUS_DIR")"
+    incus profile device add default root disk path="/" pool="incustest-$(basename "${INCUS_DIR}")"
+}
+
+nfs_teardown() {
+    # shellcheck disable=2039,3043
+    local INCUS_DIR
+
+    INCUS_DIR=$1
+
+    echo "==> Tearing down nfs backend in ${INCUS_DIR}"
+    rm -rf "/media/$(basename "$INCUS_DIR")"
+}

test/includes/clustering.sh

@@ -197,6 +197,13 @@ EOF
   config:
     source: incustest-$(basename "${TEST_DIR}" | sed 's/\./__/g')
     linstor.resource_group.place_count: 1
+EOF
+        fi
+        if [ "${driver}" = "nfs" ]; then
+            cat >> "${INCUS_DIR}/preseed.yaml" << EOF
+  config:
+    nfs.host: $INCUS_NFS_HOST
+    source: /media/$(basename "${TEST_DIR}")
 EOF
         fi
         cat >> "${INCUS_DIR}/preseed.yaml" << EOF

test/includes/incusd.sh

@@ -27,6 +27,9 @@ spawn_incus() {
     elif [ "${INCUS_BACKEND}" = "linstor" ] && [ -z "${INCUS_LINSTOR_CLUSTER:-}" ]; then
         echo "A cluster name must be specified when using the LINSTOR driver." >&2
         exit 1
+    elif [ "${INCUS_BACKEND}" = "nfs" ] && [ -z "${INCUS_NFS_HOST:-}" ]; then
+        echo "A host name must be specified when using the NFS driver." >&2
+        exit 1
     fi
 
     # setup storage

test/includes/storage.sh

@@ -48,6 +48,10 @@ available_storage_backends() {
         fi
     done
 
+    if [ -n "${INCUS_NFS_HOST:-}" ] && command -v "exportfs" > /dev/null 2>&1; then
+        backends="$backends nfs"
+    fi
+
     if [ -n "${INCUS_TRUENAS_DATASET:-}" ] && command -v "truenas_incus_ctl" > /dev/null 2>&1; then
         backends="$backends truenas"
     fi

test/main.sh

@@ -63,6 +63,9 @@ if [ "$INCUS_BACKEND" != "random" ] && ! storage_backend_available "$INCUS_BACKE
     elif [ "${INCUS_BACKEND}" = "truenas" ] && [ -z "${INCUS_TRUENAS_DATASET:-}" ]; then
         echo "TrueNAS storage backend requires that \"INCUS_TRUENAS_DATASET\" be set."
         exit 1
+    elif [ "${INCUS_BACKEND}" = "nfs" ] && [ -z "${INCUS_NFS_HOST:-}" ]; then
+        echo "LINSTOR storage backend requires that \"INCUS_NFS_HOST\" be set."
+        exit 1
     fi
     echo "Storage backend \"$INCUS_BACKEND\" is not available"
     exit 1