Add check for max number of allowed characters #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the crontab man pages, the maximum number of characters in the command field is 998 https://manpages.debian.org/jessie/cron/crontab.5.en.html. This PR adds a check to catch lines that are longer than 998. It updates the test file as well. This change was requested in this issue lyda#22 and I have run into issues with crontab failing because of lines being too long, so having the linter catch this issue will be a big help.
Contributor
|
Please make a PR to my fork: https://github.com/gregorg/chkcrontab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was requested in this issue #22, and I have run into issues with crontab failing because of commands being too long, so having the linter catch this issue will be a big help.
This PR adds a check to catch lines that are longer than 998. It updates the test file as well. According to the crontab man pages, the maximum number of characters in the command field is 998 https://manpages.debian.org/jessie/cron/crontab.5.en.html.