From 999c1c0c93a7fbadcf239d39a48ca1c5d2463a96 Mon Sep 17 00:00:00 2001 From: James Couball Date: Tue, 15 Apr 2025 15:18:52 -0700 Subject: [PATCH 1/2] refactor: make BANNER constant private --- exe/revert-github-release | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exe/revert-github-release b/exe/revert-github-release index ab096ca..3e44e8a 100755 --- a/exe/revert-github-release +++ b/exe/revert-github-release @@ -76,7 +76,7 @@ class Parser COMMAND end - private_constant BANNER = <<~BANNER.freeze + BANNER = <<~BANNER.freeze Usage: #{File.basename($PROGRAM_NAME)} [--help | --version] @@ -96,6 +96,7 @@ class Parser Options: BANNER + private_constant :BANNER # Define the options for OptionParser # @return [void] From 50ec4f437a36ad63549e292d8261e69262a02f2c Mon Sep 17 00:00:00 2001 From: James Couball Date: Tue, 15 Apr 2025 15:22:36 -0700 Subject: [PATCH 2/2] refactor: only fail the build for low coverage on non-windows MRI --- .github/workflows/continuous_integration.yml | 14 +++++++++++++- .github/workflows/experimental_ruby_builds.yml | 8 ++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/.github/workflows/continuous_integration.yml b/.github/workflows/continuous_integration.yml index b4e91c0..fc66193 100644 --- a/.github/workflows/continuous_integration.yml +++ b/.github/workflows/continuous_integration.yml @@ -25,16 +25,28 @@ jobs: runs-on: ${{ matrix.operating-system }} continue-on-error: true + env: + FAIL_ON_LOW_COVERAGE: ${{ matrix.fail_on_low_coverage }} + strategy: fail-fast: false matrix: - ruby: ["3.1", "3.2", "3.3", "jruby-9.4", "truffleruby-24"] + ruby: ["3.1", "3.4"] operating-system: [ubuntu-latest] + fail_on_low_coverage: ["true"] include: + - ruby: "jruby-9.4" + operating-system: ubuntu-latest + fail_on_low_coverage: "false" + - ruby: "truffleruby-24" + operating-system: ubuntu-latest + fail_on_low_coverage: "false" - ruby: "3.1" operating-system: windows-latest + fail_on_low_coverage: "false" - ruby: "jruby-9.4" operating-system: windows-latest + fail_on_low_coverage: "false" steps: - name: Checkout diff --git a/.github/workflows/experimental_ruby_builds.yml b/.github/workflows/experimental_ruby_builds.yml index 574f247..c95821d 100644 --- a/.github/workflows/experimental_ruby_builds.yml +++ b/.github/workflows/experimental_ruby_builds.yml @@ -22,20 +22,28 @@ jobs: runs-on: ${{ matrix.operating-system }} continue-on-error: true + env: + FAIL_ON_LOW_COVERAGE: ${{ matrix.fail_on_low_coverage }} + strategy: fail-fast: false matrix: include: - ruby: head operating-system: ubuntu-latest + fail_on_low_coverage: "true" - ruby: head operating-system: windows-latest + fail_on_low_coverage: "false" - ruby: truffleruby-head operating-system: ubuntu-latest + fail_on_low_coverage: "false" - ruby: jruby-head operating-system: ubuntu-latest + fail_on_low_coverage: "false" - ruby: jruby-head operating-system: windows-latest + fail_on_low_coverage: "false" steps: - name: Checkout