feat: make Worktree#clone work if clone_to path is not given

Also, use File#realpath to expand worktree and repository paths so that
they are determinate.

Author: jcouball

lib/ruby_git/repository.rb

@@ -27,7 +27,7 @@ class Repository
     # @param [String] repository_path the path to the repository
     #
     def initialize(repository_path)
-      @path = File.expand_path(repository_path)
+      @path = File.realpath(repository_path)
     end
   end
 end

lib/ruby_git/worktree.rb

@@ -97,11 +97,23 @@ def self.open(worktree_path)
     #
     # @return [RubyGit::Worktree] the Git working tree checked out from the cloned repository
     #
-    def self.clone(repository_url, to_path: '')
-      command = ['clone', '--', repository_url, to_path]
+    def self.clone(repository_url, to_path: nil)
+      command = ['clone', '--', repository_url]
+      command << to_path if to_path
       options = { out: StringIO.new, err: StringIO.new }
-      RubyGit::CommandLine.run(*command, **options)
-      new(to_path)
+      clone_output = RubyGit::CommandLine.run(*command, **options).stderr
+      new(cloned_to(clone_output))
+    end
+
+    # Get path of the cloned worktree from `git clone` stderr output
+    #
+    # @param clone_output [String] the stderr output of the `git clone` command
+    #
+    # @return [String] the path of the cloned worktree
+    #
+    # @api private
+    def self.cloned_to(clone_output)
+      clone_output.match(/Cloning into ['"](.+)['"]\.\.\./)[1]
     end
 
     # Show the working tree and index status
@@ -151,7 +163,7 @@ def repository
         command = %w[rev-parse --git-dir]
         options = { chdir: path, chomp: true, out: StringIO.new, err: StringIO.new }
         # rev-parse path might be relative to the worktree, thus the need to expand it
-        git_dir = File.expand_path(RubyGit::CommandLine.run(*command, **options).stdout, path)
+        git_dir = File.realpath(RubyGit::CommandLine.run(*command, **options).stdout, path)
         Repository.new(git_dir)
       end
     end
@@ -182,7 +194,7 @@ def initialize(worktree_path)
     def root_path(worktree_path)
       command = %w[rev-parse --show-toplevel]
       options = { chdir: worktree_path, chomp: true, out: StringIO.new, err: StringIO.new }
-      RubyGit::CommandLine.run(*command, **options).stdout
+      File.realpath(RubyGit::CommandLine.run(*command, **options).stdout)
     end
 
     # Run a Git command in this worktree

spec/lib/ruby_git/repository_spec.rb

@@ -2,12 +2,18 @@
 
 RSpec.describe RubyGit::Repository do
   let(:repository) { RubyGit::Repository.new(repository_path) }
+  let(:repository_path) { File.realpath(@repository_path) }
 
   describe '#initialize' do
-    subject { repository }
-
     context 'when given a repository path' do
-      let(:repository_path) { File.expand_path('/path/to/repository') }
+      around do |example|
+        in_temp_dir do |repository_path|
+          @repository_path = repository_path
+          example.run
+        end
+      end
+
+      subject { repository }
 
       it 'should set the path to the given repository path' do
         expect(subject).to have_attributes(path: repository_path)

spec/lib/ruby_git/worktree_clone_spec.rb

@@ -16,6 +16,29 @@ def make_bare_repository(repository_path)
 end
 
 RSpec.describe RubyGit::Worktree do
+  describe '.clone(url)' do
+    subject { described_class.clone(repository_url) }
+    let(:repository_url) { 'repository.git' }
+
+    around do |example|
+      in_temp_dir do |path|
+        @path = path
+
+        in_dir repository_url do
+          run %w[git init --initial-branch=main]
+        end
+        example.run
+      end
+    end
+
+    let(:expected_worktree_path) { File.realpath(File.join(@path, 'repository')) }
+
+    it 'should return a Worktree object with the correct path' do
+      expect(subject).to be_kind_of(RubyGit::Worktree)
+      expect(subject).to have_attributes(path: expected_worktree_path)
+    end
+  end
+
   describe '.clone(url, to_path: worktree_path)' do
     subject { described_class.clone(repository_url, to_path: worktree_path) }
     let(:tmpdir) { Dir.mktmpdir }

spec/lib/ruby_git/worktree_spec.rb

@@ -16,6 +16,6 @@
     subject { worktree.repository }
 
     it { is_expected.to be_a(RubyGit::Repository) }
-    it { is_expected.to have_attributes(path: File.expand_path('./.git')) }
+    it { is_expected.to have_attributes(path: File.realpath('./.git')) }
   end
 end