Skip to content

EtherDelta wrapper tests do not work without on-chain order #36

@richmcateer

Description

@richmcateer

EtherDelta works with on-chain orders and off-chain orders:

    if (!(
      (orders[user][hash] || ecrecover(sha3("\x19Ethereum Signed Message:\n32", hash),v,r,s) == user) &&
      block.number <= expires &&
      safeAdd(orderFills[user][hash], amount) <= amountGet
    )) throw;

The EtherDelta wrapper test only works for on-chain orders.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions