Symfony Process.php construct() must be of the type array, string given

[kyletaylored]

This seems to be broken when using Composer 2.3, but the underlying issue is the Symfony Process 5.4 library that expects an array, while this package is using the 2.x version.

https://github.com/symfony/process/blob/5.4/Process.php#L143

In Process.php line 143:

  [TypeError]
  Argument 1 passed to Symfony\Component\Process\Process::__construct() must be of the type array, string given, called in /project/vendor/mariusbuescher/node-composer/src/Installer/NodeInstaller.php on line 84


Exception trace:
  at phar:///opt/homebrew/Cellar/composer/2.3.2/bin/composer/vendor/symfony/process/Process.php:143

[mariusbuescher]

Due to limited time I have, I am would be really glad if you open up a PR, that fixes the issue.

[kyletaylored]

@mariusbuescher So it looks like the issue is in the symfony/process dependency, where if you're using < 4.x, it's expecting a string of a command, but >=4.x, it's expecting an array of commands.

I don't know if it's better to detect the underlying version of symfony/process, or split into a 2.x version that isolates the dependency version. Do you have a preference?

[kyletaylored]

@mariusbuescher Take a look at #17, which would address this issue. You would just need to create a 2.x release that separates the symfony/process dependency restricted to those major version differences.