Skip to content

Commit 4a7630f

Browse files
feat: Migrate com.avaloq.tools.ddk.test.ui to Junit5
1 parent 10f0def commit 4a7630f

5 files changed

Lines changed: 28 additions & 29 deletions

File tree

com.avaloq.tools.ddk.test.ui.test/META-INF/MANIFEST.MF

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,13 @@ Bundle-Version: 16.3.0.qualifier
66
Bundle-ActivationPolicy: lazy
77
Bundle-Vendor: Avaloq Group AG
88
Bundle-RequiredExecutionEnvironment: JavaSE-21
9-
Require-Bundle: org.junit,
10-
org.eclipse.swtbot.eclipse.finder,
9+
Require-Bundle: org.eclipse.swtbot.eclipse.finder,
1110
org.eclipse.swt,
1211
com.avaloq.tools.ddk.test.core,
1312
com.avaloq.tools.ddk.test.ui,
1413
junit-jupiter-api,
1514
junit-jupiter-engine,
16-
junit-vintage-engine
15+
junit-platform-suite-api
1716
Import-Package: org.eclipse.core.runtime,
1817
org.eclipse.core.runtime.jobs
1918
Automatic-Module-Name: com.avaloq.tools.ddk.test.ui.test

com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/AllTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@
1010
*******************************************************************************/
1111
package com.avaloq.tools.ddk.test.ui.test;
1212

13-
import org.junit.runner.RunWith;
13+
import org.junit.platform.suite.api.SelectClasses;
14+
import org.junit.platform.suite.api.Suite;
1415

15-
import com.avaloq.tools.ddk.test.core.junit.runners.DiscerningSuite;
1616
import com.avaloq.tools.ddk.test.ui.test.swtbot.DeChKeyboardLayoutTest;
1717
import com.avaloq.tools.ddk.test.ui.test.swtbot.SwtBotRadioTest;
1818

1919

2020
/**
2121
* Empty class serving only as holder for JUnit4 annotations.
2222
*/
23-
@RunWith(DiscerningSuite.class)
24-
@DiscerningSuite.SuiteClasses({
23+
@Suite
24+
@SelectClasses({
2525
// @Format-Off
2626
DeChKeyboardLayoutTest.class,
2727
SwtBotRadioTest.class

com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/logging/ErrorLogListenerTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010
*******************************************************************************/
1111
package com.avaloq.tools.ddk.test.ui.test.logging;
1212

13-
import static org.junit.Assert.assertFalse;
14-
import static org.junit.Assert.assertTrue;
13+
import static org.junit.jupiter.api.Assertions.assertFalse;
14+
import static org.junit.jupiter.api.Assertions.assertTrue;
1515

1616
import org.eclipse.core.runtime.IProgressMonitor;
1717
import org.eclipse.core.runtime.IStatus;
1818
import org.eclipse.core.runtime.jobs.Job;
19-
import org.junit.After;
20-
import org.junit.Before;
21-
import org.junit.Test;
19+
import org.junit.jupiter.api.AfterEach;
20+
import org.junit.jupiter.api.BeforeEach;
21+
import org.junit.jupiter.api.Test;
2222

2323
import com.avaloq.tools.ddk.test.core.util.ErrorLogListener;
2424

@@ -32,7 +32,7 @@ public class ErrorLogListenerTest {
3232
/**
3333
* Sets up the {@link ErrorLogListener} under test.
3434
*/
35-
@Before
35+
@BeforeEach
3636
public void setUp() {
3737
errorLogListener = new ErrorLogListener();
3838
errorLogListener.register();
@@ -41,7 +41,7 @@ public void setUp() {
4141
/**
4242
* Tears down the {@link ErrorLogListener} under test.
4343
*/
44-
@After
44+
@AfterEach
4545
public void tearDown() {
4646
errorLogListener.unregister();
4747
}
@@ -55,7 +55,7 @@ public void tearDown() {
5555
@Test
5656
@SuppressWarnings("nls")
5757
public void testIgnoringExceptionLocations() throws InterruptedException {
58-
assertFalse("NullPointerException must not have been logged.", errorLogListener.isExceptionLogged(NullPointerException.class));
58+
assertFalse(errorLogListener.isExceptionLogged(NullPointerException.class), "NullPointerException must not have been logged.");
5959
errorLogListener.ignoreException(NullPointerException.class, "com.avaloq.tools.ddk.test.core.util.ErrorLogListenerTest");
6060

6161
final Job job = new Job("testIgnoringExceptionLocations") {
@@ -70,6 +70,6 @@ protected IStatus run(final IProgressMonitor monitor) {
7070
job.schedule();
7171
job.join();
7272

73-
assertTrue("NullPointerException must have been logged.", errorLogListener.isExceptionLogged(NullPointerException.class));
73+
assertTrue(errorLogListener.isExceptionLogged(NullPointerException.class), "NullPointerException must have been logged.");
7474
}
7575
}

com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/DeChKeyboardLayoutTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
*******************************************************************************/
1111
package com.avaloq.tools.ddk.test.ui.test.swtbot;
1212

13-
import static org.junit.Assert.assertEquals;
13+
import static org.junit.jupiter.api.Assertions.assertEquals;
1414

1515
import org.eclipse.swtbot.eclipse.finder.widgets.SWTBotEclipseEditor;
1616
import org.eclipse.swtbot.swt.finder.utils.SWTBotPreferences;
17-
import org.junit.Test;
17+
import org.junit.jupiter.api.Test;
1818

1919
import com.avaloq.tools.ddk.test.ui.swtbot.SwtWorkbenchBot;
2020

@@ -43,6 +43,6 @@ public void testDeChKeyboardLayout() {
4343
String actualResult = editor.getText();
4444
bot.closeAllEditors();
4545

46-
assertEquals("Written and read characters must exactly match", EXPECTED_RESULT, actualResult);
46+
assertEquals(EXPECTED_RESULT, actualResult, "Written and read characters must exactly match");
4747
}
4848
}

com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/SwtBotRadioTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010
*******************************************************************************/
1111
package com.avaloq.tools.ddk.test.ui.test.swtbot;
1212

13-
import static org.junit.Assert.assertNotNull;
14-
import static org.junit.Assert.assertTrue;
13+
import static org.junit.jupiter.api.Assertions.assertNotNull;
14+
import static org.junit.jupiter.api.Assertions.assertTrue;
1515

1616
import org.eclipse.swtbot.eclipse.finder.SWTWorkbenchBot;
17-
import org.junit.Rule;
18-
import org.junit.Test;
17+
import org.junit.jupiter.api.Test;
18+
import org.junit.jupiter.api.extension.RegisterExtension;
1919

2020
import com.avaloq.tools.ddk.test.core.Issue;
21-
import com.avaloq.tools.ddk.test.core.IssueAwareRule;
21+
import com.avaloq.tools.ddk.test.core.jupiter.IssueAwareRule;
2222
import com.avaloq.tools.ddk.test.ui.swtbot.SwtWorkbenchBot;
2323
import com.avaloq.tools.ddk.test.ui.swtbot.util.PreferenceUtil;
2424

@@ -29,7 +29,7 @@
2929
@SuppressWarnings("nls")
3030
public class SwtBotRadioTest {
3131

32-
@Rule
32+
@RegisterExtension
3333
// CHECKSTYLE:CHECK-OFF VisibilityModifier
3434
public final IssueAwareRule rule = IssueAwareRule.getInstance();
3535
// CHECKSTYLE:CHECK-ON VisibilityModifier
@@ -97,17 +97,17 @@ private void testRadioButtonClick(final SWTWorkbenchBot bot) {
9797
}
9898

9999
// Assert that the buttons were found.
100-
assertNotNull("previouslySelectedRadio must not be null.", previouslySelectedRadio);
101-
assertNotNull("radioToSelect must not be null.", radioToSelect);
100+
assertNotNull(previouslySelectedRadio, "previouslySelectedRadio must not be null.");
101+
assertNotNull(radioToSelect, "radioToSelect must not be null.");
102102

103103
// Select radio button and check if it was actually selected.
104104
bot.radio(radioToSelect.getText()).click();
105-
assertTrue(String.format("\"%s\" must be selected.", radioToSelect.getText()), bot.radio(radioToSelect.getText()).isSelected());
105+
assertTrue(bot.radio(radioToSelect.getText()).isSelected(), String.format("\"%s\" must be selected.", radioToSelect.getText()));
106106

107107
// Close and re-open preference page and check again.
108108
PreferenceUtil.closePreferenceDialog(bot);
109109
PreferenceUtil.openPreferenceDialog(bot, PREFERENCES_PATH);
110-
assertTrue(String.format("\"%s\" must not be de-selected again.", radioToSelect.getText()), bot.radio(radioToSelect.getText()).isSelected());
110+
assertTrue(bot.radio(radioToSelect.getText()).isSelected(), String.format("\"%s\" must not be de-selected again.", radioToSelect.getText()));
111111

112112
// Reset
113113
bot.radio(previouslySelectedRadio.getText()).click();

0 commit comments

Comments
 (0)