Merge pull request #166 from marmelab/string-comparisons

Allow to use `_gt` and `_lt` filters with strings

Author: fzaninotto

src/introspection/getFilterTypesFromData.js

@@ -23,6 +23,7 @@ const getRangeFiltersFromEntities = (entities) => {
         if (
             fieldType == GraphQLInt ||
             fieldType == GraphQLFloat ||
+            fieldType.name == GraphQLString ||
             fieldType.name == 'Date'
         ) {
             fields[`${fieldName}_lt`] = { type: fieldType };

src/introspection/getFilterTypesFromData.spec.js

@@ -7,12 +7,14 @@ const data = {
             title: 'Lorem Ipsum',
             views: 254,
             user_id: 123,
+            published: true,
         },
         {
             id: 2,
             title: 'Sic Dolor amet',
             views: 65,
             user_id: 456,
+            published: true,
         },
     ],
     users: [
@@ -85,8 +87,8 @@ test('creates 4 fields for number field for range filters', () => {
     expect(PostFilterFields.views_gte.type.toString()).toEqual('Int');
 });
 
-test('does not create vomparison fiels for non-number fields', () => {
+test('does not create comparison fields for fields that do not support it', () => {
     const filterTypes = getFilterTypesFromData(data);
     const PostFilterFields = filterTypes.Post.getFields();
-    expect(PostFilterFields.title_lte).toBeUndefined();
+    expect(PostFilterFields.published_lte).toBeUndefined();
 });