i18n: notifications.group needs plural forms

[gunchleoc]

Expected behaviour

correct plural markup

Actual behaviour

no plural markup

Detailed description

I'd like to get rid of this ugly translation workaround:

My issue on Crowdin got put aside because the number is "bigger than 5", which is not how natural languages work.

https://crowdin.com/editor/mastodon/52/en-gd?view=comfortable#5120

Mastodon instance

any

Mastodon version

any

Browser name and version

any

Operating system

any

Technical details

No response

[diondiondion]

I'm not 100% sure I understand the issue, but the code using this translations is being passed a count property:

mastodon/app/javascript/mastodon/service_worker/web_push_notifications.js

Line 15 in 08ae77f

title: formatMessage('notifications.group', options.data.preferred_locale, { count: notifications.length + 1 }),

So you should be able to add plural forms as needed using the ICU message format for plurals, e.g. it'd look like this for English, with # substituting the count:

{count, plural, one {One notification} other {# notifications}}

Polish and Russian also make use of this already:

"notifications.group": "{count, number} {count, plural, one {powiadomienie} few {powiadomienia} many {powiadomień} more {powiadomień}}",

"notifications.group": "{count, plural, one {# уведомление}, few {# уведомления}, other {# уведомлений}}",