Changes from code review

Author: duncanpo

CMakeLists.txt

@@ -195,7 +195,8 @@ if(NOT DEFINED OTEL_CPP_INSTALLED_DIR)
 
    set(OTEL_CPP_CXX_STANDARD 14)
 
-   set(OTEL_ABI_VERSION OPENTELEMETRY_ABI_VERSION_NO=2)
+   # The synchronous gauge metric instrument is only defined in ABI version 2
+   set(OTEL_CPP_ABI_VERSION OPENTELEMETRY_ABI_VERSION_NO=2)
 
    set(PATCHES_DIR ${CMAKE_SOURCE_DIR}/patches)
    if(SKIP_OTEL_CPP_PATCH)
@@ -370,7 +371,7 @@ if(WITH_OTLP_FILE)
     target_compile_definitions(${OPENTELEMETRY_PROXY_LIBRARY_NAME} PRIVATE WITH_OTLP_FILE)
 endif()
 
-target_compile_definitions(${OPENTELEMETRY_PROXY_LIBRARY_NAME} PRIVATE ${OTEL_ABI_VERSION})
+target_compile_definitions(${OPENTELEMETRY_PROXY_LIBRARY_NAME} PRIVATE ${OTEL_CPP_ABI_VERSION})
 
 # pass in version number
 target_compile_definitions(${OPENTELEMETRY_PROXY_LIBRARY_NAME} PRIVATE OTEL_MATLAB_VERSION="${OTEL_MATLAB_VERSION}")

examples/context_propagation/CMakeLists.txt

@@ -8,7 +8,8 @@ if(NOT DEFINED OTEL_CPP_INSTALLED_DIR)
     add_dependencies(${CONTEXTPROP_EXAMPLE_CPP_TARGET} ${OTEL_CPP_PROJECT_NAME})
 endif()
 
-target_compile_definitions(${CONTEXTPROP_EXAMPLE_CPP_TARGET} PRIVATE ${OTEL_ABI_VERSION})
+# Specify the ABI version, include directories, and libraries of otel-cpp. The C++ code in this example directly calls otel-cpp functions.
+target_compile_definitions(${CONTEXTPROP_EXAMPLE_CPP_TARGET} PRIVATE ${OTEL_CPP_ABI_VERSION})
 target_include_directories(${CONTEXTPROP_EXAMPLE_CPP_TARGET} PRIVATE ${OTEL_CPP_PREFIX}/include)
 target_link_libraries(${CONTEXTPROP_EXAMPLE_CPP_TARGET} PRIVATE ${OPENTELEMETRY_PROXY_LINK_LIBRARIES})
 if(UNIX AND NOT APPLE AND NOT CYGWIN)

examples/webread/CMakeLists.txt

@@ -5,7 +5,8 @@ if(NOT DEFINED OTEL_CPP_INSTALLED_DIR)
     add_dependencies(${WEBREAD_EXAMPLE_TARGET} ${OTEL_CPP_PROJECT_NAME})
 endif()
 
-target_compile_definitions(${WEBREAD_EXAMPLE_TARGET} PRIVATE ${OTEL_ABI_VERSION})
+# Specify the ABI version, include directories, and libraries of otel-cpp. The C++ code in this example directly calls otel-cpp functions.
+target_compile_definitions(${WEBREAD_EXAMPLE_TARGET} PRIVATE ${OTEL_CPP_ABI_VERSION})
 target_include_directories(${WEBREAD_EXAMPLE_TARGET} PRIVATE ${OTEL_CPP_PREFIX}/include)
 target_link_libraries(${WEBREAD_EXAMPLE_TARGET} PRIVATE ${OPENTELEMETRY_PROXY_LINK_LIBRARIES})
 if(UNIX AND NOT APPLE AND NOT CYGWIN)

sdk/common/+opentelemetry/+sdk/+common/addDefaultResource.m

@@ -1,4 +1,13 @@
 function [keys, values] = addDefaultResource(keys, values)
+% Add default resource attributes
+%    [KEYS, VALUES] = OPENTELEMETRY.SDK.COMMON.ADDDEFAULTRESOURCE(KEYS,
+%    VALUES) appends default resource attribute names and values to the
+%    input attribute names and values. The appended attribute names and
+%    values are returned as output. Default resource attributes are
+%    attributes that are always included in all telemetry data generated in
+%    this package.
+
+% Copyright 2025 The MathWorks, Inc.
 
 % MATLAB version
 v = string(version);