-
Notifications
You must be signed in to change notification settings - Fork 340
crypto: use a new withheld code when history is marked as "not shareable" #5807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
57467f9 to
aa07079
Compare
aa07079 to
6bfd968
Compare
CodSpeed Performance ReportMerging #5807 will not alter performanceComparing Summary
|
c008db8 to
3d0e189
Compare
| )) | ||
| } | ||
| _ => unreachable!("Can't create an unknown withheld code content"), | ||
| WithheldCode::_Custom(_) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the wildcard pattern in a few enums, so that it's harder to miss places when adding new withheld codes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5807 +/- ##
==========================================
+ Coverage 88.50% 88.52% +0.02%
==========================================
Files 360 360
Lines 100719 100731 +12
Branches 100719 100731 +12
==========================================
+ Hits 89138 89177 +39
+ Misses 7396 7371 -25
+ Partials 4185 4183 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Add an integration test that ensures that the correct withheld code is sent when history is marked as "not shareable"
855075b to
ef3c671
Compare
MSC4268 now defines a new withheld code for use when the session is not marked as
shared_history: start using it, and add a test to make sure it is sent correctly.part of element-hq/element-meta#2876