Inspect & fixs some code

Author: mcsong

Library/src/main/java/net/sjava/appstore/AmazonAppStore.java

@@ -12,8 +12,8 @@
  * @version 1.0.0
  */
 public class AmazonAppStore extends AppStore implements PublisherAppOpenable {
-	static String APPSTORE_URI = "amzn://apps/android?";
-	static String APP_URL = "http://www.amazon.com/gp/mas/dl/android?";
+	private static final String APPSTORE_URI = "amzn://apps/android?";
+	private static final String APP_URL = "http://www.amazon.com/gp/mas/dl/android?";
 
 	public static AmazonAppStore newInstance() {
 		return new AmazonAppStore();

Library/src/main/java/net/sjava/appstore/AppStore.java

@@ -5,7 +5,6 @@
 import android.content.pm.ApplicationInfo;
 import android.content.pm.PackageManager;
 
-import java.util.Iterator;
 import java.util.List;
 /**
  * AppStore abstract class
@@ -30,9 +29,12 @@ private List<ApplicationInfo> getApplications(Context ctx) {
 	}
 
 	protected boolean isAppInstalled(Context ctx, String packageName) {
-		Iterator<ApplicationInfo> itr = getApplications(ctx).iterator();
-		while (itr.hasNext()) {
-			if (itr.next().packageName.indexOf(packageName) != -1)
+		List<ApplicationInfo> apps = getApplications(ctx);
+		if(apps == null || apps.size() == 0)
+			return false;
+
+		for(ApplicationInfo appinfo : apps) {
+			if(appinfo.packageName.contains(packageName))
 				return true;
 		}
 

Library/src/main/java/net/sjava/appstore/NaverAppStore.java

@@ -12,7 +12,7 @@
  * @version 1.0.0
  */
 public class NaverAppStore extends AppStore {
-	static String APP_URL ="http://nstore.naver.com/appstore/web/detail.nhn?productNo=";
+	private static final String APP_URL ="http://nstore.naver.com/appstore/web/detail.nhn?productNo=";
 
 	public static NaverAppStore newInstance() {
 		return new NaverAppStore();

Library/src/main/java/net/sjava/appstore/PlayAppStore.java

@@ -12,8 +12,8 @@
  * @version 1.0.0
  */
 public class PlayAppStore extends AppStore implements PublisherAppOpenable {
-	static String APP_URL = "http://play.google.com/store/apps/deails?id=";
-	static String APP_SEARCH_URL = "http://play.google.com/store/search?q=";
+	private static final String APP_URL = "http://play.google.com/store/apps/deails?id=";
+	private static final String APP_SEARCH_URL = "http://play.google.com/store/search?q=";
 
 	public static PlayAppStore newInstance() {
 		return new PlayAppStore();

Library/src/main/java/net/sjava/appstore/TAppStore.java

@@ -12,7 +12,7 @@
  * @version 1.0.0
  */
 public class TAppStore extends AppStore {
-	private static String APP_URL = "http://m.tstore.co.kr/mobilepoc/apps/appsDetail.omp?prodId=";
+	private static final String APP_URL = "http://m.tstore.co.kr/mobilepoc/apps/appsDetail.omp?prodId=";
 
 	public static TAppStore newInstance() {
 		return new TAppStore();