Skip to content

Commit fec7f51

Browse files
committed
Update Temporal timezone test to be on par with main
1 parent ca6e4b7 commit fec7f51

File tree

2 files changed

+52
-12
lines changed

2 files changed

+52
-12
lines changed

src/temporal/timezone.test.js

Lines changed: 50 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,49 +21,89 @@ describe('tzOffset', () => {
2121

2222
describe('in boundaries', () => {
2323

24-
test('tzOffset(-8) is -08:00', () => {
24+
test('tzOffset(-23, -59) is -23:59', () => {
25+
expect(tzOffset(-23, -59)).toBe('-23:59')
26+
})
27+
28+
test('tzOffset(-9, -30) is -09:30', () => {
29+
expect(tzOffset(-9, -30)).toBe('-09:30')
30+
})
31+
32+
test('tzOffset(-9, 30) is -08:30', () => {
33+
expect(tzOffset(-9, 30)).toBe('-08:30')
34+
})
35+
36+
test('tzOffset(-8) is -08:00', () => {
2537
expect(tzOffset(-8)).toBe('-08:00')
2638
})
2739

28-
test('tzOffset(-4.5) is -04:30', () => {
40+
test('tzOffset(-4.5) is -04:30', () => {
2941
expect(tzOffset(-4.5)).toBe('-04:30')
3042
})
3143

32-
test('tzOffset(0, -30) is -00:30', () => {
44+
test('tzOffset(0, -30) is -00:30', () => {
3345
expect(tzOffset(0, -30)).toBe('-00:30')
3446
})
3547

36-
test('tzOffset(0) is Z', () => {
48+
test('tzOffset(0) is Z', () => {
3749
expect(tzOffset(0)).toBe('Z')
3850
})
3951

40-
test('tzOffset(0, 30) is +00:30', () => {
52+
test('tzOffset(0, 30) is +00:30', () => {
4153
expect(tzOffset(0, 30)).toBe('+00:30')
4254
})
4355

44-
test('tzOffset(1) is +01:00', () => {
56+
test('tzOffset(1) is +01:00', () => {
4557
expect(tzOffset(1)).toBe('+01:00')
4658
})
4759

48-
test('tzOffset(2, -200) is -01:20', () => {
60+
test('tzOffset(2, -200) is -01:20', () => {
4961
expect(tzOffset(2, -200)).toBe('-01:20')
5062
})
5163

52-
test('tzOffset(4, 30) is +04:30', () => {
64+
test('tzOffset(4, 30) is +04:30', () => {
5365
expect(tzOffset(4, 30)).toBe('+04:30')
5466
})
5567

56-
test('tzOffset(12, 45) is +12:45', () => {
68+
test('tzOffset(12, 45) is +12:45', () => {
5769
expect(tzOffset(12, 45)).toBe('+12:45')
5870
})
5971

60-
test('tzOffset(12.75) is +12:45', () => {
72+
test('tzOffset(12.75) is +12:45', () => {
6173
expect(tzOffset(12.75)).toBe('+12:45')
6274
})
75+
76+
test('tzOffset(23, 59) is +23:59', () => {
77+
expect(tzOffset(23, 59)).toBe('+23:59')
78+
})
6379
})
6480

6581
describe('out of boundaries', () => {
6682

83+
test('tzOffset(-24) is Z', () => {
84+
expect(tzOffset(-24)).toBe('Z')
85+
})
86+
87+
test('tzOffset(24) is Z', () => {
88+
expect(tzOffset(24)).toBe('Z')
89+
})
90+
91+
test('tzOffset(-24, 0, true) is Z', () => {
92+
expect(tzOffset(-24, 0, true)).toBe('Z')
93+
})
94+
95+
test('tzOffset(24, 0, true) is Z', () => {
96+
expect(tzOffset(24, 0, true)).toBe('Z')
97+
})
98+
99+
test('tzOffset(-24, -1) is -00:01', () => {
100+
expect(tzOffset(-24, -1)).toBe('-00:01')
101+
})
102+
103+
test('tzOffset(24, 1) is 00:01', () => {
104+
expect(tzOffset(24, 1)).toBe('+00:01')
105+
})
106+
67107
test('tzOffset(-35) is -11:00', () => {
68108
expect(tzOffset(-35)).toBe('-11:00')
69109
})

src/temporal/utils/const.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
export const MINUTES_PER_DAY = 60 * 24
22
export const MILLISECONDS_PER_DAY = 1000 * 60 * 60 * 24
33
export const MILLISECONDS_PER_WEEK = MILLISECONDS_PER_DAY * 7
4-
export const REAL_LIFE_LOWER_TIMEZONE = -12 * 60
5-
export const REAL_LIFE_UPPER_TIMEZONE = 14 * 60
4+
export const REAL_LIFE_LOWER_TIMEZONE = -12 * 60 // -12:00
5+
export const REAL_LIFE_UPPER_TIMEZONE = 14 * 60 // +14:00
66

77
// Local timezone offset from UTC, in minutes
88
export const LOCAL_TZ_OFFSET = (new Date()).getTimezoneOffset() * -1

0 commit comments

Comments
 (0)